From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Clean up PCI config register handling
Date: Mon, 18 Apr 2016 20:14:33 +0300 [thread overview]
Message-ID: <87inzeu9dy.fsf@intel.com> (raw)
In-Reply-To: <20160418152655.GM18964@nuc-i3427.alporthouse.com>
On Mon, 18 Apr 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> [ text/plain ]
> On Mon, Apr 18, 2016 at 06:09:28PM +0300, Joonas Lahtinen wrote:
>> @@ -251,7 +245,7 @@ static int swsci(struct drm_device *dev, u32 function, u32 parm, u32 *parm_out)
>> struct drm_i915_private *dev_priv = dev->dev_private;
>> struct opregion_swsci *swsci = dev_priv->opregion.swsci;
>> u32 main_function, sub_function, scic;
>> - u16 pci_swsci;
>> + u16 swsci_reg;
>
> This threw me. In other places _reg means the register offset and _val
> means the value we want to poke into the register.
IMO you could just leave it as pci_swsci.
BR,
Jani.
>
> Happy with everything else.
> -Chris
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-18 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 9:17 [PATCH] drm/i915: Clean up PCI config register handling Joonas Lahtinen
2016-04-15 9:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-15 10:18 ` [PATCH] " Chris Wilson
2016-04-18 15:09 ` Joonas Lahtinen
2016-04-18 15:26 ` Chris Wilson
2016-04-18 17:14 ` Jani Nikula [this message]
2016-04-19 13:07 ` [PATCH v3] " Joonas Lahtinen
2016-04-18 15:56 ` ✗ Fi.CI.BAT: failure for drm/i915: Clean up PCI config register handling (rev2) Patchwork
2016-04-19 14:06 ` ✗ Fi.CI.BAT: failure for drm/i915: Clean up PCI config register handling (rev3) Patchwork
2016-04-19 14:21 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inzeu9dy.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.