From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: Remove duplicate `const` qualifier Date: Tue, 09 Feb 2016 17:28:43 +0200 Message-ID: <87io1x2990.fsf@intel.com> References: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F006F6E5A3 for ; Tue, 9 Feb 2016 07:29:45 -0800 (PST) In-Reply-To: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Engestrom , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwOSBGZWIgMjAxNiwgRXJpYyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0cm9tQGltZ3Rl Yy5jb20+IHdyb3RlOgo+IENvbW1pdCAxZWI4MzQ1IGFkZGVkIGEgYnVuY2ggb2YgbGVnaXRpbWF0 ZSBgY29uc3RgLCBidXQgYWRkZWQgdHdvIG9uCj4gdGhhdCBsaW5lLgoKVG9vIGxhdGUsIGZpeGVk IGluCgpjb21taXQgNzBjMDYxNmQ1YTg0NThhZTkxNDhkNzQzMDljZWRlMDdiYTJmNTE2NApBdXRo b3I6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+CkRhdGU6ICAgV2Vk IEphbiAyMCAxMDo1OTozNCAyMDE2ICswMDAwCgogICAgZHJtL2ZiX2NtYV9oZWxwZXI6IHJlbW92 ZSBkdXBsaWNhdGUgY29uc3QgZnJvbSBkcm1fZmJfY21hX2FsbG9jCgpCUiwKSmFuaS4KCgo+Cj4g U2lnbmVkLW9mZi1ieTogRXJpYyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0cm9tQGltZ3RlYy5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jIHwgMiArLQo+ICAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZmJfY21hX2hlbHBlci5jCj4gaW5kZXggYzg5NWI2Zi4uYzQzMDlkZiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gQEAgLTc0LDcgKzc0LDcgQEAgc3RhdGljIHN0 cnVjdCBkcm1fZnJhbWVidWZmZXJfZnVuY3MgZHJtX2ZiX2NtYV9mdW5jcyA9IHsKPiAgfTsKPiAg Cj4gIHN0YXRpYyBzdHJ1Y3QgZHJtX2ZiX2NtYSAqZHJtX2ZiX2NtYV9hbGxvYyhzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+IC0JY29uc3QgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1v ZGVfY21kLCBzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICoqb2JqLAo+ICsJY29uc3Qgc3RydWN0 IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kLCBzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICoq b2JqLAo+ICAJdW5zaWduZWQgaW50IG51bV9wbGFuZXMpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZmJf Y21hICpmYl9jbWE7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757171AbcBIP3r (ORCPT ); Tue, 9 Feb 2016 10:29:47 -0500 Received: from mga02.intel.com ([134.134.136.20]:5827 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756103AbcBIP3q (ORCPT ); Tue, 9 Feb 2016 10:29:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,421,1449561600"; d="scan'208";a="911631889" From: Jani Nikula To: Eric Engestrom , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Remove duplicate `const` qualifier In-Reply-To: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com> User-Agent: Notmuch/0.21+34~g7dd0d52 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 09 Feb 2016 17:28:43 +0200 Message-ID: <87io1x2990.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Feb 2016, Eric Engestrom wrote: > Commit 1eb8345 added a bunch of legitimate `const`, but added two on > that line. Too late, fixed in commit 70c0616d5a8458ae9148d74309cede07ba2f5164 Author: Colin Ian King Date: Wed Jan 20 10:59:34 2016 +0000 drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc BR, Jani. > > Signed-off-by: Eric Engestrom > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index c895b6f..c4309df 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = { > }; > > static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev, > - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj, > + const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj, > unsigned int num_planes) > { > struct drm_fb_cma *fb_cma; -- Jani Nikula, Intel Open Source Technology Center