All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: "Pan\, Miaoqing" <miaoqing@qti.qualcomm.com>,
	Stephan Mueller <smueller@chronox.de>, "Sepehrdad\,
	Pouyan" <pouyans@qti.qualcomm.com>, "Jacobson\,
	David" <djacobso@qti.qualcomm.com>,
	Oleksij Rempel <linux@rempel-privat.de>,
	"linville\@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, "Theodore Ts'o" <tytso@mit.edu>,
	"linux-crypto\@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"nhorman\@tuxdriver.com" <nhorman@tuxdriver.com>
Subject: Re: [PATCH 2/2] ath9k: export HW random number generator
Date: Wed, 25 Nov 2015 11:16:22 +0200	[thread overview]
Message-ID: <87io4qphg9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAFtRNNyWzRKQbq1wa8=6V=tOQzB3g9jEBLhAO7iSchNAzf=fkQ@mail.gmail.com> (Nick Kossifidis's message of "Sat, 7 Nov 2015 17:39:21 -0600")

Nick Kossifidis <mickflemm@gmail.com> writes:

> That was partially my intention too when I submitted
> 2aa56cca3571fd08c0c38f3e2d4bb0bfb3def3c5 which mixes FFT measurements
> to the entropy pool without providing any estimation on entropy
> (entropy estimation is the wrong approach, read the papers on fortuna
> for more information on that). I believe that this approach is better
> than mine because FFT data is too much (high throughput) and may have
> a negative impact on the pool when mixed like this (even without the
> entropy count) so Kale please revert my patch also (I was about to
> submit a request for reverting it and writing something similar when
> this thread came up).

Could you submit the revert as a patch and with the explonation in the
commit log, please?

-- 
Kalle Valo

  parent reply	other threads:[~2015-11-25  9:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  7:54 [PATCH 1/2] ath9k: Fix register definitions for QCA956x miaoqing
2015-07-15  7:54 ` [PATCH 2/2] ath9k: export HW random number generator miaoqing
2015-07-26  7:41   ` Oleksij Rempel
2015-07-27  6:50     ` Pan, Miaoqing
     [not found]       ` <a8b787bd17d94e8899bf1be6131165b2-Y81KQx/RBXvl7IBs54+zFqRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org>
2015-07-27 10:45         ` Oleksij Rempel
2015-07-27 10:45           ` Oleksij Rempel
2015-07-27 11:01           ` Stephan Mueller
     [not found]             ` <3945775.m5HblJPgiO-gNvIQDDl/k7Ia13z/PHSgg@public.gmane.org>
2015-07-28 17:41               ` Sandy Harris
2015-07-28 17:41                 ` Sandy Harris
     [not found]                 ` <CACXcFmnUcf66+X967JQL9mGrpa6ZYOqz99oK6JV8nFzABn=NZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-29  6:33                   ` Stephan Mueller
2015-07-29  6:33                     ` Stephan Mueller
2015-07-31  7:08               ` Kalle Valo
2015-07-31  7:08                 ` Kalle Valo
     [not found]                 ` <8738043ith.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-07-31  8:39                   ` Pan, Miaoqing
2015-07-31  8:39                     ` Pan, Miaoqing
2015-11-07 23:39                     ` Nick Kossifidis
2015-11-07 23:59                       ` Nick Kossifidis
2015-11-25  9:16                       ` Kalle Valo [this message]
2015-07-21 14:30 ` [PATCH 1/2] ath9k: Fix register definitions for QCA956x Kalle Valo
2015-07-21 15:04 ` [1/2] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io4qphg9.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=djacobso@qti.qualcomm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=linville@tuxdriver.com \
    --cc=miaoqing@qti.qualcomm.com \
    --cc=mickflemm@gmail.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pouyans@qti.qualcomm.com \
    --cc=smueller@chronox.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.