From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGYT-0007yN-16
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:32:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGYP-0001rE-0G
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:32:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58701)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGYO-0001rA-Qs
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:32:52 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1444710158-8723-1-git-send-email-eblake@redhat.com>
	<1444710158-8723-16-git-send-email-eblake@redhat.com>
	<87zizm6c67.fsf@blackfin.pond.sub.org> <561D24CA.7030804@redhat.com>
	<87mvvmvghf.fsf@blackfin.pond.sub.org> <561D42C3.1050207@redhat.com>
	<87wpuqmxex.fsf@blackfin.pond.sub.org>
Date: Wed, 14 Oct 2015 09:32:49 +0200
In-Reply-To: <87wpuqmxex.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Tue, 13 Oct 2015 20:32:54 +0200")
Message-ID: <87io697vmm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member
	checks to schema check()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
>
>> On 10/13/2015 11:13 AM, Markus Armbruster wrote:
>>
>>>>>
>>>>> I've come to the conclusion that we should get rid of the self-inflicted
>>>>> pain before we attempt to detect all collisions.
>>>>
>>>> Then that sounds like I should try harder to get the kind/type naming,
>>>> the boxed base naming, and even the anonymous union naming all hoisted
>>>> into this subset, and spin a v9?
>>> 
>>> I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two
>>> redundant is_implicit() methods dropped, and PATCH 12's comment touched
>>> up.
>>
>> Okay.
>
> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.

Redone & pushed.

Summary of tweaks:
* PATCH 01-06.5: unchanged
* PATCH 07: your fixup to drop is_implicit() squashed in
* PATCH 08: array info plumbing moved to PATCH 12
* PATCH 09: trivially rebased
* PATCH 12: revert your fixup, so we get the move we want, adjust commit
  message accordingly, supply missing QAPISchemaArrayType.is_implicit()

The end result is the same except for

diff --git a/scripts/qapi.py b/scripts/qapi.py
index dad381d..8a12b91 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -939,6 +939,9 @@ class QAPISchemaArrayType(QAPISchemaType):
         self.element_type = schema.lookup_type(self._element_type_name)
         assert self.element_type
 
+    def is_implicit(self):
+        return True
+
     def json_type(self):
         return 'array'
 

[...]