From: Yasushi SHOJI <yashi@atmark-techno.com>
To: linux-media@vger.kernel.org
Subject: Re: [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device *HACK*
Date: Thu, 01 Oct 2015 21:08:34 +0900 [thread overview]
Message-ID: <87io6qdc59.wl@dns1.atmark-techno.com> (raw)
In-Reply-To: <1661627.kAJPFnURo3@avalon>
Hi,
Sorry to follow up on an old message, but:
On Fri, 31 Oct 2014 19:41:33 +0900,
Laurent Pinchart wrote:
>
> On Thursday 02 October 2014 18:09:47 Michael Grzeschik wrote:
> > Currently the uvc_driver is not cleaning up its child devices if a
> > device is still in use. It leads to orphaned devices which are not
> > sitting on any interface. They get cleaned up on uvc_delete which will
> > be called on uvc_remove after the userspace application is closing the
> > stream. When PM_RUNTIME is used in the kernel, this leads to the
> > following backtrace for missing sysfs entries in the orphaned kobjects.
> >
> > This patch is moving the device cleanup code for the child devices from
> > uvc_delete to uvc_unregister_video. It is an *HACK* workaround which
> > is ment to initiate the discussion for a proper solution.
>
> Does https://patchwork.linuxtv.org/patch/26561/ help ? The usb_put_intf() and
> usb_put_dev() calls could be moved to the end of the function to fix the
> media_device_unregister() warning.
26561 does not seem to help, since I can reproduce the warning on 4.2.1
4.2.0-1-amd64 #1 SMP Debian 4.2.1-2 (2015-09-27) x86_64 GNU/Linux
I haven't tried Michael's yet, but it seems, at least to me, that many
subsystem are having similar problem and proper fixes must be applied
per subsystem. Is that the case right now?
ref:
- https://bugzilla.redhat.com/show_bug.cgi?id=1174075
- http://thread.gmane.org/gmane.linux.usb.general/119218/focus=85560
- mention that this "is not new"
- http://thread.gmane.org/gmane.linux.scsi/86237/focus=88328
--
yashi
prev parent reply other threads:[~2015-10-01 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 16:09 [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device *HACK* Michael Grzeschik
2014-10-07 9:24 ` [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device Michael Grzeschik
2014-10-31 10:41 ` [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device *HACK* Laurent Pinchart
2015-10-01 12:08 ` Yasushi SHOJI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io6qdc59.wl@dns1.atmark-techno.com \
--to=yashi@atmark-techno.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.