From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0271041975757276332==" MIME-Version: 1.0 From: Jani Nikula To: lkp@lists.01.org Subject: Re: [PATCH] drm/i915: disable CPU PWM also on LPT/SPT backlight disable Date: Tue, 29 Sep 2015 15:49:15 +0300 Message-ID: <87io6tie5w.fsf@intel.com> In-Reply-To: <1443530508-12112-1-git-send-email-jani.nikula@intel.com> List-Id: --===============0271041975757276332== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Also adding Cc: intel-gfx, please include that in follow-ups. Thanks, Jani. On Tue, 29 Sep 2015, Jani Nikula wrote: > Although we don't support or enable CPU PWM with LPT/SPT based systems, > it may have been enabled prior to loading the driver. Disable the CPU > PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable. > > The issue has been present on BDW since BDW enabling, but was recently > introduced on HSW with > > commit 437b15b8017e0d946453c10794b0c5d4591cf180 > Author: Jani Nikula > Date: Fri Sep 4 16:55:13 2015 +0300 > > drm/i915: use pch backlight override on hsw too > > Reference: http://mid.gmane.org/87y4frhwsn.fsf(a)yhuang-dev.intel.com > Reported-by: kernel test robot > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in= tel_panel.c > index dd71e7f139e3..c9c94d05f3dd 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -731,6 +731,20 @@ static void lpt_disable_backlight(struct intel_conne= ctor *connector) > = > intel_panel_actually_set_backlight(connector, 0); > = > + /* > + * Although we don't support or enable CPU PWM with LPT/SPT based > + * systems, it may have been enabled prior to loading the > + * driver. Disable to avoid warnings on LCPLL disable. > + * > + * This needs rework if we need to add support for CPU PWM on PCH split > + * platforms. > + */ > + tmp =3D I915_READ(BLC_PWM_CPU_CTL2); > + if (tmp & BLM_PWM_ENABLE) { > + DRM_DEBUG_KMS("cpu backlight was enabled, disabling\n"); > + I915_WRITE(BLC_PWM_CPU_CTL2, tmp & ~BLM_PWM_ENABLE); > + } > + > tmp =3D I915_READ(BLC_PWM_PCH_CTL1); > I915_WRITE(BLC_PWM_PCH_CTL1, tmp & ~BLM_PCH_PWM_ENABLE); > } > -- = > 2.1.4 > -- = Jani Nikula, Intel Open Source Technology Center --===============0271041975757276332==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: disable CPU PWM also on LPT/SPT backlight disable Date: Tue, 29 Sep 2015 15:49:15 +0300 Message-ID: <87io6tie5w.fsf@intel.com> References: <87y4fpmyqi.fsf@yhuang-dev.intel.com> <1443530508-12112-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 095886E7B3 for ; Tue, 29 Sep 2015 05:45:57 -0700 (PDT) In-Reply-To: <1443530508-12112-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Huang Ying Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , LKML , kernel test robot , lkp@01.org List-Id: intel-gfx@lists.freedesktop.org CkFsc28gYWRkaW5nIENjOiBpbnRlbC1nZngsIHBsZWFzZSBpbmNsdWRlIHRoYXQgaW4gZm9sbG93 LXVwcy4KClRoYW5rcywKSmFuaS4KCk9uIFR1ZSwgMjkgU2VwIDIwMTUsIEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBpbnRlbC5jb20+IHdyb3RlOgo+IEFsdGhvdWdoIHdlIGRvbid0IHN1cHBvcnQg b3IgZW5hYmxlIENQVSBQV00gd2l0aCBMUFQvU1BUIGJhc2VkIHN5c3RlbXMsCj4gaXQgbWF5IGhh dmUgYmVlbiBlbmFibGVkIHByaW9yIHRvIGxvYWRpbmcgdGhlIGRyaXZlci4gRGlzYWJsZSB0aGUg Q1BVCj4gUFdNIG9uIExQVC9TUFQgYmFja2xpZ2h0IGRpc2FibGUgdG8gYXZvaWQgd2FybmluZ3Mg b24gTENQTEwgZGlzYWJsZS4KPgo+IFRoZSBpc3N1ZSBoYXMgYmVlbiBwcmVzZW50IG9uIEJEVyBz aW5jZSBCRFcgZW5hYmxpbmcsIGJ1dCB3YXMgcmVjZW50bHkKPiBpbnRyb2R1Y2VkIG9uIEhTVyB3 aXRoCj4KPiBjb21taXQgNDM3YjE1YjgwMTdlMGQ5NDY0NTNjMTA3OTRiMGM1ZDQ1OTFjZjE4MAo+ IEF1dGhvcjogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBEYXRlOiAgIEZy aSBTZXAgNCAxNjo1NToxMyAyMDE1ICswMzAwCj4KPiAgICAgZHJtL2k5MTU6IHVzZSBwY2ggYmFj a2xpZ2h0IG92ZXJyaWRlIG9uIGhzdyB0b28KPgo+IFJlZmVyZW5jZTogaHR0cDovL21pZC5nbWFu ZS5vcmcvODd5NGZyaHdzbi5mc2ZAeWh1YW5nLWRldi5pbnRlbC5jb20KPiBSZXBvcnRlZC1ieTog a2VybmVsIHRlc3Qgcm9ib3QgPHlpbmcuaHVhbmdAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgfCAxNCArKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hh bmdlZCwgMTQgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4g aW5kZXggZGQ3MWU3ZjEzOWUzLi5jOWM5NGQwNWYzZGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BhbmVsLmMKPiBAQCAtNzMxLDYgKzczMSwyMCBAQCBzdGF0aWMgdm9pZCBscHRfZGlzYWJs ZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAKPiAgCWlu dGVsX3BhbmVsX2FjdHVhbGx5X3NldF9iYWNrbGlnaHQoY29ubmVjdG9yLCAwKTsKPiAgCj4gKwkv Kgo+ICsJICogQWx0aG91Z2ggd2UgZG9uJ3Qgc3VwcG9ydCBvciBlbmFibGUgQ1BVIFBXTSB3aXRo IExQVC9TUFQgYmFzZWQKPiArCSAqIHN5c3RlbXMsIGl0IG1heSBoYXZlIGJlZW4gZW5hYmxlZCBw cmlvciB0byBsb2FkaW5nIHRoZQo+ICsJICogZHJpdmVyLiBEaXNhYmxlIHRvIGF2b2lkIHdhcm5p bmdzIG9uIExDUExMIGRpc2FibGUuCj4gKwkgKgo+ICsJICogVGhpcyBuZWVkcyByZXdvcmsgaWYg d2UgbmVlZCB0byBhZGQgc3VwcG9ydCBmb3IgQ1BVIFBXTSBvbiBQQ0ggc3BsaXQKPiArCSAqIHBs YXRmb3Jtcy4KPiArCSAqLwo+ICsJdG1wID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ ICsJaWYgKHRtcCAmIEJMTV9QV01fRU5BQkxFKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiY3B1IGJh Y2tsaWdodCB3YXMgZW5hYmxlZCwgZGlzYWJsaW5nXG4iKTsKPiArCQlJOTE1X1dSSVRFKEJMQ19Q V01fQ1BVX0NUTDIsIHRtcCAmIH5CTE1fUFdNX0VOQUJMRSk7Cj4gKwl9Cj4gKwo+ICAJdG1wID0g STkxNV9SRUFEKEJMQ19QV01fUENIX0NUTDEpOwo+ICAJSTkxNV9XUklURShCTENfUFdNX1BDSF9D VEwxLCB0bXAgJiB+QkxNX1BDSF9QV01fRU5BQkxFKTsKPiAgfQo+IC0tIAo+IDIuMS40Cj4KCi0t IApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964862AbbI2MqF (ORCPT ); Tue, 29 Sep 2015 08:46:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:33985 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934787AbbI2Mp5 (ORCPT ); Tue, 29 Sep 2015 08:45:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,608,1437462000"; d="scan'208";a="815271861" From: Jani Nikula To: Huang Ying Cc: kernel test robot , lkp@01.org, LKML , Clint Taylor , Daniel Vetter , "intel-gfx\@lists.freedesktop.org" Subject: Re: [PATCH] drm/i915: disable CPU PWM also on LPT/SPT backlight disable In-Reply-To: <1443530508-12112-1-git-send-email-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87y4fpmyqi.fsf@yhuang-dev.intel.com> <1443530508-12112-1-git-send-email-jani.nikula@intel.com> User-Agent: Notmuch/0.20.2+58~g39779b9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 29 Sep 2015 15:49:15 +0300 Message-ID: <87io6tie5w.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Also adding Cc: intel-gfx, please include that in follow-ups. Thanks, Jani. On Tue, 29 Sep 2015, Jani Nikula wrote: > Although we don't support or enable CPU PWM with LPT/SPT based systems, > it may have been enabled prior to loading the driver. Disable the CPU > PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable. > > The issue has been present on BDW since BDW enabling, but was recently > introduced on HSW with > > commit 437b15b8017e0d946453c10794b0c5d4591cf180 > Author: Jani Nikula > Date: Fri Sep 4 16:55:13 2015 +0300 > > drm/i915: use pch backlight override on hsw too > > Reference: http://mid.gmane.org/87y4frhwsn.fsf@yhuang-dev.intel.com > Reported-by: kernel test robot > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index dd71e7f139e3..c9c94d05f3dd 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -731,6 +731,20 @@ static void lpt_disable_backlight(struct intel_connector *connector) > > intel_panel_actually_set_backlight(connector, 0); > > + /* > + * Although we don't support or enable CPU PWM with LPT/SPT based > + * systems, it may have been enabled prior to loading the > + * driver. Disable to avoid warnings on LCPLL disable. > + * > + * This needs rework if we need to add support for CPU PWM on PCH split > + * platforms. > + */ > + tmp = I915_READ(BLC_PWM_CPU_CTL2); > + if (tmp & BLM_PWM_ENABLE) { > + DRM_DEBUG_KMS("cpu backlight was enabled, disabling\n"); > + I915_WRITE(BLC_PWM_CPU_CTL2, tmp & ~BLM_PWM_ENABLE); > + } > + > tmp = I915_READ(BLC_PWM_PCH_CTL1); > I915_WRITE(BLC_PWM_PCH_CTL1, tmp & ~BLM_PCH_PWM_ENABLE); > } > -- > 2.1.4 > -- Jani Nikula, Intel Open Source Technology Center