From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zcwax-0002Km-VL
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:25:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zcwat-0002Kd-2T
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:24:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zcwas-0002KJ-Ty
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:24:55 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1442577640-11612-1-git-send-email-armbru@redhat.com>
	<1442577640-11612-8-git-send-email-armbru@redhat.com>
	<55FC093B.7000507@suse.de>
Date: Fri, 18 Sep 2015 16:24:52 +0200
In-Reply-To: <55FC093B.7000507@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?=
	=?utf-8?Q?'s?= message of "Fri, 18 Sep 2015 14:53:15 +0200")
Message-ID: <87io77st3f.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/7] tests: Simplify how qom-test is run
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, ehabkost@redhat.com

Andreas F=C3=A4rber <afaerber@suse.de> writes:

> Am 18.09.2015 um 14:00 schrieb Markus Armbruster:
>> Add it to check-qtest-generic-y instead of check-qtest-$(target)-y for
>> every target.
>>=20
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  tests/Makefile | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>=20
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 4559045..28c5f93 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -219,10 +219,7 @@ gcov-files-ppc64-y +=3D ppc64-softmmu/hw/ppc/spapr_=
pci.c
>>  check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y)
>>  check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y)
>>=20=20
>> -# qom-test works for all sysemu architectures:
>> -$(foreach target,$(SYSEMU_TARGET_LIST), \
>> - $(if $(findstring tests/qom-test$(EXESUF),
>> $(check-qtest-$(target)-y)),, \
>> -		$(eval check-qtest-$(target)-y +=3D tests/qom-test$(EXESUF))))
>> +check-qtest-generic-y +=3D tests/qom-test$(EXESUF)
>
> Does this -generic- have the same filtering code to avoid running the
> tests twice for x86_64, aarch64, ppc64, etc.? Please don't regress.

I'm dense today.  Can you explain the filtering code to me?

[...]