All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths
Date: Mon, 14 Sep 2015 18:43:21 +0200	[thread overview]
Message-ID: <87io7dgdee.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <3FBFD05D-A0A4-4A2C-A235-39923ECA7FAE@gmail.com> (Programmingkid's message of "Mon, 14 Sep 2015 12:17:20 -0400")

Programmingkid <programmingkidx@gmail.com> writes:

> On Sep 14, 2015, at 11:53 AM, Markus Armbruster wrote:
[...]
>> If neither Andreas nor Paolo objects, I'd be willing to take this
>> through my tree.
>
> If you do accept this patch, would you still be willing to
> accept an auto-generated ID patch still?

I'm on record saying

    I believe [this patch] makes sense no matter what we do about device
    IDs (see thread "Should we auto-generate IDs?").

This patch weakens *one* reason for auto-generated IDs: device_del
without ID is impossible before, and merely a bit inconvenient after.  I
haven't been able to keep up with the discussion on auto-generated IDs,
so I can't currently judge how strong the other reasons are.

  parent reply	other threads:[~2015-09-14 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 12:33 [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths Daniel P. Berrange
2015-09-11 12:46 ` Eric Blake
2015-09-14 15:53 ` Markus Armbruster
2015-09-14 16:17   ` Programmingkid
2015-09-14 16:41     ` Eric Blake
2015-09-14 16:49       ` Programmingkid
2015-09-14 17:08         ` Eric Blake
2015-09-14 16:43     ` Markus Armbruster [this message]
2015-09-14 16:54       ` Programmingkid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io7dgdee.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.