From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYyQa-0005FD-CA for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:33:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYyQW-0002kO-8E for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:33:52 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYyQW-0002k8-34 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:33:48 -0400 Received: by wicge5 with SMTP id ge5so87961222wic.0 for ; Mon, 07 Sep 2015 08:33:47 -0700 (PDT) References: <1440375847-17603-1-git-send-email-cota@braap.org> <1440375847-17603-2-git-send-email-cota@braap.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1440375847-17603-2-git-send-email-cota@braap.org> Date: Mon, 07 Sep 2015 16:33:45 +0100 Message-ID: <87io7m9rc6.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC 01/38] cpu-exec: add missing mmap_lock in tb_find_slow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: mttcg@listserver.greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, Frederic Konrad Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > cpu-exec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cpu-exec.c b/cpu-exec.c > index f53475c..b8a11e1 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -330,6 +330,7 @@ static TranslationBlock *tb_find_slow(CPUState *cpu, > if (!tb) { > tb = tb_gen_code(cpu, pc, cs_base, flags, 0); > } > + mmap_unlock(); > } > > /* we add the TB in the virtual pc hash table */ Fix the commit comment s/lock/unlock/ and you can have: Reviewed-by: Alex Bennée -- Alex Bennée