From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Subject: Re: [PATCH v8 08/11] xen: arch-specific hooks for domain_soft_reset() Date: Thu, 16 Jul 2015 13:36:18 +0200 Message-ID: <87io9kwczx.fsf@vitty.brq.redhat.com> References: <1435075913-335-1-git-send-email-vkuznets@redhat.com> <1435075913-335-9-git-send-email-vkuznets@redhat.com> <55A6C054.1040903@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFhSl-0005jH-CL for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 11:36:27 +0000 In-Reply-To: <55A6C054.1040903@citrix.com> (Julien Grall's message of "Wed, 15 Jul 2015 22:19:32 +0200") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Wei Liu , Andrew Jones , Keir Fraser , Ian Campbell , Stefano Stabellini , Andrew Cooper , Julien Grall , Ian Jackson , Olaf Hering , Tim Deegan , David Vrabel , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org Julien Grall writes: > Hi Vitaly, > > On 23/06/2015 18:11, Vitaly Kuznetsov wrote: >> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >> index 24b8938..c112afa 100644 >> --- a/xen/arch/arm/domain.c >> +++ b/xen/arch/arm/domain.c >> @@ -653,6 +653,11 @@ void arch_domain_unpause(struct domain *d) >> { >> } >> >> +int arch_domain_soft_reset(struct domain *d) >> +{ >> + return 0; > > I suspect that it would needs some code in this function in order to > support soft reset on ARM. If so, should not you return -ENOSYS until > someone take care of the ARM support? > I was hoping kexec for ARM will magically work without any arch-specific bits here :-) Sure, let's make it -ENOSYS. >> +} >> + > > Regards, -- Vitaly