From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Pz7-0007Ya-AV for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8Pz4-0001F8-36 for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:31:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Pz3-0001Ew-Ux for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:31:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9A0CD2FB8A2 for ; Fri, 26 Jun 2015 09:31:41 +0000 (UTC) From: Markus Armbruster References: <1435239307-13369-1-git-send-email-lersek@redhat.com> <1435239307-13369-3-git-send-email-lersek@redhat.com> Date: Fri, 26 Jun 2015 11:31:39 +0200 In-Reply-To: <1435239307-13369-3-git-send-email-lersek@redhat.com> (Laszlo Ersek's message of "Thu, 25 Jun 2015 15:35:06 +0200") Message-ID: <87ioaa24uc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Jan Tomko , John Snow , qemu-devel@nongnu.org, Paolo Bonzini Laszlo Ersek writes: > With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: > > -device isa-fdc,driveA=drive-fdc0-0-0 \ > -drive file=...,if=none,id=drive-fdc0-0-0,format=raw > > then the board-default FDC will be skipped, and only the explicitly > requested FDC will exist. qtree-wise, this is correct; however such an FDC > is currently not registered in the CMOS, because that code is only reached > for the board-default FDC. > > The pc_cmos_init_late() one-shot reset handler -- one-shot because the > CMOS is not reprogrammed during warm reset -- should search for any ISA > FDC devices, created implicitly (by board code) or explicitly, and set the > CMOS accordingly to the ISA FDC(s) with iobase=0x3f0: > > - if there is no such FDC, report both drives absent, > - if there is exactly one such FDC, report its drives in the CMOS, > - if there are more than one such FDCs, then pick one (it is not specified > which one), and print a warning about the ambiguity. > > Cc: Jan Tomko > Cc: John Snow > Cc: Markus Armbruster > Cc: Paolo Bonzini > Reported-by: Jan Tomko > Suggested-by: Markus Armbruster > Signed-off-by: Laszlo Ersek > Reviewed-by: John Snow Reviewed-by: Markus Armbruster