All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
	intel-gfx@lists.freedesktop.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line
Date: Fri, 06 Mar 2015 09:54:25 +0200	[thread overview]
Message-ID: <87ioeetvbi.fsf@intel.com> (raw)
In-Reply-To: <1425574649.31859.14.camel@perches.com>

On Thu, 05 Mar 2015, Joe Perches <joe@perches.com> wrote:
> Only commit log and patch additions are checked for
> typos and spelling errors currently.  Add a check
> of the email subject line too.
>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks Joe.

FWIW,

Tested-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 421bbb4..c061a63 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2303,7 +2303,8 @@ sub process {
>  		}
>  
>  # Check for various typo / spelling mistakes
> -		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
> +		if (defined($misspellings) &&
> +		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
>  				my $typo = $1;
>  				my $typo_fix = $spelling_fix{lc($typo)};
>
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Purushothaman, Vijay A" <vijay.a.purushothaman@linux.intel.com>,
	"Andy Whitcroft" <apw@canonical.com>,
	LKML <linux-kernel@vger.kernel.org>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line
Date: Fri, 06 Mar 2015 09:54:25 +0200	[thread overview]
Message-ID: <87ioeetvbi.fsf@intel.com> (raw)
In-Reply-To: <1425574649.31859.14.camel@perches.com>

On Thu, 05 Mar 2015, Joe Perches <joe@perches.com> wrote:
> Only commit log and patch additions are checked for
> typos and spelling errors currently.  Add a check
> of the email subject line too.
>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks Joe.

FWIW,

Tested-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 421bbb4..c061a63 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2303,7 +2303,8 @@ sub process {
>  		}
>  
>  # Check for various typo / spelling mistakes
> -		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
> +		if (defined($misspellings) &&
> +		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
>  				my $typo = $1;
>  				my $typo_fix = $spelling_fix{lc($typo)};
>
>

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2015-03-06  7:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 19:01 [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz ville.syrjala
2015-03-01  3:52 ` shuang.he
2015-03-04 14:41 ` Purushothaman, Vijay A
2015-03-04 15:10   ` Ville Syrjälä
2015-03-04 15:15     ` Daniel Vetter
2015-03-05  7:43     ` checkpatch spell checking (was: Re: [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz) Jani Nikula
2015-03-05  7:43       ` checkpatch spell checking (was: Re: [Intel-gfx] " Jani Nikula
2015-03-05 10:43       ` Joe Perches
2015-03-05 16:57       ` [PATCH] checkpatch: Add spell checking of email subject line Joe Perches
2015-03-05 16:57         ` Joe Perches
2015-03-06  7:54         ` Jani Nikula [this message]
2015-03-06  7:54           ` Jani Nikula
2015-03-06  8:40         ` [PATCH] checkpatch: spell check reudce Jani Nikula
2015-03-06  8:40           ` Jani Nikula
2015-03-06 11:41           ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioeetvbi.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.