From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line Date: Fri, 06 Mar 2015 09:54:25 +0200 Message-ID: <87ioeetvbi.fsf@intel.com> References: <1424977312-24902-1-git-send-email-ville.syrjala@linux.intel.com> <54F719A2.50405@linux.intel.com> <20150304151002.GS11371@intel.com> <87twxz3n4p.fsf@intel.com> <1425574649.31859.14.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D0786E892 for ; Thu, 5 Mar 2015 23:53:03 -0800 (PST) In-Reply-To: <1425574649.31859.14.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Perches , Andrew Morton Cc: Andy Whitcroft , intel-gfx@lists.freedesktop.org, LKML List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNSBNYXIgMjAxNSwgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4gd3JvdGU6 Cj4gT25seSBjb21taXQgbG9nIGFuZCBwYXRjaCBhZGRpdGlvbnMgYXJlIGNoZWNrZWQgZm9yCj4g dHlwb3MgYW5kIHNwZWxsaW5nIGVycm9ycyBjdXJyZW50bHkuICBBZGQgYSBjaGVjawo+IG9mIHRo ZSBlbWFpbCBzdWJqZWN0IGxpbmUgdG9vLgo+Cj4gU3VnZ2VzdGVkLWJ5OiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvZSBQZXJjaGVz IDxqb2VAcGVyY2hlcy5jb20+CgpUaGFua3MgSm9lLgoKRldJVywKClRlc3RlZC1ieTogSmFuaSBO aWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gLS0tCj4gIHNjcmlwdHMvY2hlY2twYXRj aC5wbCB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKPgo+IGRpZmYgLS1naXQgYS9zY3JpcHRzL2NoZWNrcGF0Y2gucGwgYi9zY3JpcHRzL2No ZWNrcGF0Y2gucGwKPiBpbmRleCA0MjFiYmI0Li5jMDYxYTYzIDEwMDc1NQo+IC0tLSBhL3Njcmlw dHMvY2hlY2twYXRjaC5wbAo+ICsrKyBiL3NjcmlwdHMvY2hlY2twYXRjaC5wbAo+IEBAIC0yMzAz LDcgKzIzMDMsOCBAQCBzdWIgcHJvY2VzcyB7Cj4gIAkJfQo+ICAKPiAgIyBDaGVjayBmb3IgdmFy aW91cyB0eXBvIC8gc3BlbGxpbmcgbWlzdGFrZXMKPiAtCQlpZiAoZGVmaW5lZCgkbWlzc3BlbGxp bmdzKSAmJiAoJGluX2NvbW1pdF9sb2cgfHwgJGxpbmUgPX4gL15cKy8pKSB7Cj4gKwkJaWYgKGRl ZmluZWQoJG1pc3NwZWxsaW5ncykgJiYKPiArCQkgICAgKCRpbl9jb21taXRfbG9nIHx8ICRsaW5l ID1+IC9eKD86XCt8U3ViamVjdDopL2kpKSB7Cj4gIAkJCXdoaWxlICgkcmF3bGluZSA9fiAvKD86 XnxbXmEtekBdKSgkbWlzc3BlbGxpbmdzKSg/OiR8W15hLXpAXSkvZ2kpIHsKPiAgCQkJCW15ICR0 eXBvID0gJDE7Cj4gIAkJCQlteSAkdHlwb19maXggPSAkc3BlbGxpbmdfZml4e2xjKCR0eXBvKX07 Cj4KPgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982AbbCFHxH (ORCPT ); Fri, 6 Mar 2015 02:53:07 -0500 Received: from mga02.intel.com ([134.134.136.20]:47128 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbbCFHxE (ORCPT ); Fri, 6 Mar 2015 02:53:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,351,1422950400"; d="scan'208";a="687821841" From: Jani Nikula To: Joe Perches , Andrew Morton Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , "Purushothaman\, Vijay A" , Andy Whitcroft , LKML , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] checkpatch: Add spell checking of email subject line In-Reply-To: <1425574649.31859.14.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1424977312-24902-1-git-send-email-ville.syrjala@linux.intel.com> <54F719A2.50405@linux.intel.com> <20150304151002.GS11371@intel.com> <87twxz3n4p.fsf@intel.com> <1425574649.31859.14.camel@perches.com> User-Agent: Notmuch/0.19+67~g70b5ead (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 06 Mar 2015 09:54:25 +0200 Message-ID: <87ioeetvbi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Mar 2015, Joe Perches wrote: > Only commit log and patch additions are checked for > typos and spelling errors currently. Add a check > of the email subject line too. > > Suggested-by: Jani Nikula > Signed-off-by: Joe Perches Thanks Joe. FWIW, Tested-by: Jani Nikula > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 421bbb4..c061a63 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2303,7 +2303,8 @@ sub process { > } > > # Check for various typo / spelling mistakes > - if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) { > + if (defined($misspellings) && > + ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { > while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) { > my $typo = $1; > my $typo_fix = $spelling_fix{lc($typo)}; > > -- Jani Nikula, Intel Open Source Technology Center