All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Roberts <neil@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Add the predicate source registers to the register whitelist
Date: Fri, 09 Jan 2015 16:41:10 +0000	[thread overview]
Message-ID: <87iogf6h5l.fsf@intel.com> (raw)
In-Reply-To: <20141111152650.GC25711@phenom.ffwll.local>

Hi,

Daniel Vetter <daniel@ffwll.ch> writes:

> Ok, I've merged this one, since that means you at least won't get an
> -EINVAL. But you can't yet enable the feature in mesa since it's still
> no-opped out. Let's hope that v3 actually starts granting rights (but
> please don't encode that in any merge mesa patch before it's official in
> the kernel, Dave Airlie _will_ revert it even if it breaks the build) and
> that this happens soon.

Thanks for merging the patch.

The current patch proposed for Mesa only enables the feature if the
version is >= 2 *and* it can successfully do a pipeline write to some
other register. Checking whether it can write to a register is already
used to decide whether to enable some transform feedback extensions and
indirect draw calls. I think in that case it should be safe to land the
Mesa patches even though it would only work on IvyBridge and not Haswell
or Gen8+. If we fix the kernel to allow the write for Haswell too then I
think it would magically start working without any extra changes. I'm
not really sure if I understand what you're saying about it being
no-opped. It's effectively not no-opped on IvyBridge so I think we
should already be able to enable the feature. Do you agree?

- Neil

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-01-09 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 15:34 [PATCH] drm/i915: Add the predicate source registers to the register whitelist Neil Roberts
2014-11-07 16:34 ` Volkin, Bradley D
2014-11-07 19:00 ` [PATCH v2] " Neil Roberts
2014-11-11 15:26   ` Daniel Vetter
2015-01-09 16:41     ` Neil Roberts [this message]
2015-01-12 23:00       ` Daniel Vetter
2014-11-07 19:33 ` [PATCH] " Kenneth Graunke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iogf6h5l.fsf@intel.com \
    --to=neil@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.