From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1C3G-0006pu-Ex for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:42:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1C3A-0008TT-9g for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:41:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1C3A-0008TJ-29 for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:41:48 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBHAfkRg028840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 17 Dec 2014 05:41:47 -0500 From: Markus Armbruster References: <1415156231-6319-1-git-send-email-famz@redhat.com> <1415156231-6319-4-git-send-email-famz@redhat.com> Date: Wed, 17 Dec 2014 11:41:43 +0100 In-Reply-To: <1415156231-6319-4-git-send-email-famz@redhat.com> (Fam Zheng's message of "Wed, 5 Nov 2014 10:57:11 +0800") Message-ID: <87iohawobc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 3/3] qemu-iotests: Test blockdev-backup in 055 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , mreitz@redhat.com Fam Zheng writes: > This applies cases on drive-backup on blockdev-backup, except cases with > target format and mode. > > Also add a case to check source == target. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/055 | 211 +++++++++++++++++++++++++++++++++++++-------- > tests/qemu-iotests/055.out | 4 +- > 2 files changed, 176 insertions(+), 39 deletions(-) I rather like how you changed this from v1. Diffstat then was 236 insertions(+), 45 deletions(-).