From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file
Date: Thu, 04 Dec 2014 21:41:45 +0100 [thread overview]
Message-ID: <87iohrywom.fsf@free.fr> (raw)
In-Reply-To: <1417691402-28166-1-git-send-email-dbaryshkov@gmail.com> (Dmitry Eremin-Solenikov's message of "Thu, 4 Dec 2014 14:10:00 +0300")
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes:
> Add regulator_has_full_constraints() call to corgi board file to let
> regulator core know that we do not have any additional regulators left.
> This lets it substitute unprovided regulators with dummy ones.
>
> This fixes the following warnings that can be seen on corgi if
> regulators are enabled:
>
> ads7846 spi1.0: unable to get regulator: -517
> spi spi1.0: Driver ads7846 requests probe deferral
> wm8731 0-001b: Failed to get supply 'AVDD': -517
> wm8731 0-001b: Failed to request supplies: -517
> wm8731 0-001b: ASoC: failed to probe component -517
> corgi-audio corgi-audio: ASoC: failed to instantiate card -517
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> arch/arm/mach-pxa/corgi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
> index 06022b2..89f790d 100644
> --- a/arch/arm/mach-pxa/corgi.c
> +++ b/arch/arm/mach-pxa/corgi.c
> @@ -26,6 +26,7 @@
> #include <linux/i2c.h>
> #include <linux/i2c/pxa-i2c.h>
> #include <linux/io.h>
> +#include <linux/regulator/machine.h>
> #include <linux/spi/spi.h>
> #include <linux/spi/ads7846.h>
> #include <linux/spi/corgi_lcd.h>
> @@ -752,6 +753,8 @@ static void __init corgi_init(void)
> sharpsl_nand_partitions[1].size = 53 * 1024 * 1024;
>
> platform_add_devices(devices, ARRAY_SIZE(devices));
> +
> + regulator_has_full_constraints();
> }
>
> static void __init fixup_corgi(struct tag *tags, char **cmdline)
Added Mark for review, as I was thinking regulator_has_full_constraints() was to
be used to disable unused regulators, a bit like in the clock framework, rather
than provide a way to provide automatically dummy regulators.
If Mark acks, I'll take the serie.
--
Robert
next prev parent reply other threads:[~2014-12-04 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 11:10 [PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file Dmitry Eremin-Solenikov
2014-12-04 11:10 ` [PATCH 2/3] ARM: pxa: add regulator_has_full_constraints to poodle " Dmitry Eremin-Solenikov
2014-12-04 11:10 ` [PATCH 3/3] ARM: pxa: add regulator_has_full_constraints to spitz " Dmitry Eremin-Solenikov
2014-12-04 20:41 ` Robert Jarzmik [this message]
2014-12-04 20:49 ` [PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi " Mark Brown
2014-12-04 21:20 ` Robert Jarzmik
2014-12-07 16:03 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iohrywom.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.