Re: [PATCH] add aio/dio regression test race between write and fcntl V2

[Dmitry Monakhov <dmonakhov@openvz.org>]

[-- Attachment #1: Type: text/plain, Size: 2960 bytes --]

Dave Chinner <david@fromorbit.com> writes:

> On Thu, Oct 09, 2014 at 06:57:22PM +0400, Dmitry Monakhov wrote:
>> Original report: https://lkml.org/lkml/2014/10/8/545
>> perform AIO-DIO and fcntl(F_SETFL) concurently
>> Unaligned AIO likely result in synchronization which makes racewindow wider.
>> 
>> changes from v1->v2
>>  - Properly reuse aio context
>
> Couple of things below....
>
>> 
>> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>> ---
>>  src/aio-dio-regress/aio-dio-fcntl-race.c |  148 ++++++++++++++++++++++++++++++
>>  tests/generic/326                        |   51 ++++++++++
>>  tests/generic/326.out                    |    2 +
>>  tests/generic/group                      |    1 +
>>  4 files changed, 202 insertions(+), 0 deletions(-)
>>  create mode 100644 src/aio-dio-regress/aio-dio-fcntl-race.c
>>  create mode 100755 tests/generic/326
>>  create mode 100644 tests/generic/326.out
>> 
>> diff --git a/src/aio-dio-regress/aio-dio-fcntl-race.c b/src/aio-dio-regress/aio-dio-fcntl-race.c
>> new file mode 100644
>> index 0000000..835dbdf
>> --- /dev/null
>> +++ b/src/aio-dio-regress/aio-dio-fcntl-race.c
>> @@ -0,0 +1,148 @@
>> +/*
>> + * Perform aio writes to file and toggle O_DIRECT flag concurrently
>> + * this may trigger race between file->f_flags read and modification
>> + * unuligned aio allow to makes race window wider.
>> + * Regression test for https://lkml.org/lkml/2014/10/8/545
>> + *
>> + * Copyright (C) 2010 Red Hat, Inc. All Rights reserved.
>
> YOu must have copied the code from somewhere. Can you add a note to
> say where it came from in the patch description? And if you added
> any significant modifications, you should add your own copyright to
> it as well...
>
>> diff --git a/tests/generic/326 b/tests/generic/326
>> new file mode 100755
>> index 0000000..8975a91
>> --- /dev/null
>> +++ b/tests/generic/326
>> @@ -0,0 +1,51 @@
>> +#! /bin/bash
>> +# FS QA Test No. 326
>
> Can you rename this to the first unused generic test?
Ok. I thought that I should use latest_used+1.
And copy-paste other aio-dio test.
I've fixed './new' script according to your comments and regenerated the test
Please find updated version in your mbox
Message-Id: <1413295189-28530-1-git-send-email-dmonakhov@openvz.org>
Message-Id: <1413295189-28530-2-git-send-email-dmonakhov@openvz.org>
>
>> +# Run aio-dio-fcntl-race - test aio write race with O_DIRECT toggle
>> +#
>> +#-----------------------------------------------------------------------
>> +# Copyright (c) 2009 Dmitry Monakhov.  All Rights Reserved.
>
> 2009 doesn't seem right for a test that was just written...

>
> Cheers,
>
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]