Re: [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 27 Aug 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Instead of going through hoops, just put the driver author directly as
> DRM_AUTHOR() argument. This will also make it consistent when we add
> Intel to the list.
>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 3 ++-
>  drivers/gpu/drm/i915/i915_drv.h | 2 --
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c4cf1af..f886922 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1707,6 +1707,7 @@ static void __exit i915_exit(void)
>  module_init(i915_init);
>  module_exit(i915_exit);
>  
> -MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_AUTHOR("Tungsten Graphics, Inc.");
> +
>  MODULE_DESCRIPTION(DRIVER_DESC);
>  MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 71e36d2..5957db4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -50,8 +50,6 @@
>  /* General customization:
>   */
>  
> -#define DRIVER_AUTHOR		"Tungsten Graphics, Inc."
> -
>  #define DRIVER_NAME		"i915"
>  #define DRIVER_DESC		"Intel Graphics"
>  #define DRIVER_DATE		"20140822"
> -- 
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center