From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: thp: Add write barrier after updating the valid bit
Date: Tue, 29 Jul 2014 16:07:32 +0530 [thread overview]
Message-ID: <87iomgwivn.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1406617244.4935.81.camel@pasglop>
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Tue, 2014-07-29 at 12:25 +0530, Aneesh Kumar K.V wrote:
>> We want to make sure for usage like below we don't reorder the load.
>>
>> if (pmd_trans_huge(*pmdp)){
>>
>> get_hpte_slot_array(pmdp)
>> }
>
> Shouldn't we also make sure that we don't have lock set ? (In case it's
> in the middle of being updated).
The reace against withdraw is not a real problem. We use
get_hpte_slot_array in huge page invalidate and hash page. In the first
case we are holding pmd_trans_huge_lock and in the later we have the
_PAGE_BUSY check.
-aneesh
next prev parent reply other threads:[~2014-07-29 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 14:52 [PATCH] powerpc: thp: Add write barrier after updating the valid bit Aneesh Kumar K.V
2014-07-22 5:27 ` Benjamin Herrenschmidt
2014-07-22 18:53 ` Aneesh Kumar K.V
2014-07-22 21:55 ` Benjamin Herrenschmidt
2014-07-29 6:55 ` Aneesh Kumar K.V
2014-07-29 7:00 ` Benjamin Herrenschmidt
2014-07-29 10:37 ` Aneesh Kumar K.V [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-15 14:51 Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iomgwivn.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.