From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCn2f-0006C7-H0 for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:20:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCn2a-00027Z-Ny for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:20:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCn2a-00027L-EH for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:20:36 -0500 From: Markus Armbruster References: <1391853717-3837-1-git-send-email-pbonzini@redhat.com> <52F63E05.409@suse.de> Date: Mon, 10 Feb 2014 10:20:29 +0100 In-Reply-To: <52F63E05.409@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Sat, 08 Feb 2014 15:24:05 +0100") Message-ID: <87iosnb9ya.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/14] Cleanup qdev legacy properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , Peter Maydell Andreas F=C3=A4rber writes: > Paolo, > > Am 08.02.2014 11:01, schrieb Paolo Bonzini: >> Anthony, Peter, >>=20 >> The following changes since commit 0169c511554cb0014a00290b0d3d26c31a498= 18f: >>=20 >> Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-0= 1-24 15:52:44 -0800) >>=20 >> are available in the git repository at: >>=20 >> git://github.com/bonzini/qemu.git qdev-props >>=20 >> for you to fetch changes up to 94fb9add077db8a8f0be3796f44785694c4686bb: >>=20 >> qapi: refine human printing of sizes (2014-02-08 10:44:41 +0100) >>=20 >> ---------------------------------------------------------------- >> Paolo Bonzini (14): >> qapi: add size parser to StringInputVisitor >> qdev: sizes are now parsed by StringInputVisitor >> qdev: remove legacy parsers for hex8/32/64 >> qdev: legacy properties are now read-only >> qdev: legacy properties are just strings >> qdev: inline qdev_prop_parse >> qapi: add human mode to StringOutputVisitor >> qdev: use human mode in "info qtree" >> qdev: remove most legacy printers >> qdev: remove hex8/32/64 property types >> block: handle "rechs" and "large" translation options >> qdev: add enum property types to QAPI schema >> qdev: use QAPI type names for properties >> qapi: refine human printing of sizes > > I had specifically requested to review and take these through qom-next, > like most qdev changes have gone lately. Why are you sending a pull > nontheless? In particular Luiz has not yet replied to the QERR issue I > pointed out. I guess Luiz didn't reply for the same reason I didn't chime in then: Paolo and Eric explained the use of QERR_INVALID_PARAMETER_TYPE adquately. You're right to challenge new uses of QERR_*, but the use you spotted is appropriate, since we want consistency with the existing visitors. [...]