* [PATCH] bs_sheepdog.c: add missing initialization of request header
@ 2013-12-19 11:16 Ryusuke Konishi
2013-12-19 13:24 ` [sheepdog] " Hitoshi Mitake
2013-12-19 13:48 ` FUJITA Tomonori
0 siblings, 2 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2013-12-19 11:16 UTC (permalink / raw)
To: stgt; +Cc: sheepdog, Ryusuke Konishi, Hitoshi Mitake
The create_branch function of the sheepdog driver sends a partially
uninitialized request to sheepdog. This fixes the defect.
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
---
usr/bs_sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/usr/bs_sheepdog.c b/usr/bs_sheepdog.c
index f11b693..59b2d25 100644
--- a/usr/bs_sheepdog.c
+++ b/usr/bs_sheepdog.c
@@ -1116,6 +1116,7 @@ static int create_branch(struct sheepdog_access_info *ai)
unsigned int wlen = 0, rlen;
int ret;
+ memset(&hdr, 0, sizeof(hdr));
hdr.opcode = SD_OP_DEL_VDI;
hdr.vdi_id = ai->inode.vdi_id;
hdr.flags = SD_FLAG_CMD_WRITE;
--
1.7.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [sheepdog] [PATCH] bs_sheepdog.c: add missing initialization of request header
2013-12-19 11:16 [PATCH] bs_sheepdog.c: add missing initialization of request header Ryusuke Konishi
@ 2013-12-19 13:24 ` Hitoshi Mitake
2013-12-19 13:48 ` FUJITA Tomonori
1 sibling, 0 replies; 3+ messages in thread
From: Hitoshi Mitake @ 2013-12-19 13:24 UTC (permalink / raw)
To: Ryusuke Konishi; +Cc: stgt, Hitoshi Mitake, sheepdog
At Thu, 19 Dec 2013 20:16:17 +0900,
Ryusuke Konishi wrote:
>
> The create_branch function of the sheepdog driver sends a partially
> uninitialized request to sheepdog. This fixes the defect.
>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> ---
> usr/bs_sheepdog.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your fix, looks good to me.
Reviewed-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
Thanks,
Hitoshi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bs_sheepdog.c: add missing initialization of request header
2013-12-19 11:16 [PATCH] bs_sheepdog.c: add missing initialization of request header Ryusuke Konishi
2013-12-19 13:24 ` [sheepdog] " Hitoshi Mitake
@ 2013-12-19 13:48 ` FUJITA Tomonori
1 sibling, 0 replies; 3+ messages in thread
From: FUJITA Tomonori @ 2013-12-19 13:48 UTC (permalink / raw)
To: konishi.ryusuke; +Cc: stgt, sheepdog, mitake.hitoshi
On Thu, 19 Dec 2013 20:16:17 +0900
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> The create_branch function of the sheepdog driver sends a partially
> uninitialized request to sheepdog. This fixes the defect.
>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> ---
> usr/bs_sheepdog.c | 1 +
> 1 file changed, 1 insertion(+)
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-19 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 11:16 [PATCH] bs_sheepdog.c: add missing initialization of request header Ryusuke Konishi
2013-12-19 13:24 ` [sheepdog] " Hitoshi Mitake
2013-12-19 13:48 ` FUJITA Tomonori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.