From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org
Subject: Re: pwm-backlight: 3.13-rc1 regression for old arm machine
Date: Tue, 17 Dec 2013 19:31:21 +0100 [thread overview]
Message-ID: <87iounuy6e.fsf@free.fr> (raw)
In-Reply-To: <20131217095658.GD13823@ulmo.nvidia.com> (Thierry Reding's message of "Tue, 17 Dec 2013 10:57:00 +0100")
Thierry Reding <thierry.reding@gmail.com> writes:
> I hadn't anticipated that =(. In fact I had been holding this patch back
> for a release cycle because I was waiting for a specific regulator patch
> to land which provides a dummy regulator if one wasn't specified. It
> seems that that patch only works when booting from DT, though.
>
> The correct way to fix this would be to provide a lookup table with the
> dummy regulator in the board file. I've attached a patch (compile-tested
> only) that might work.
>
> If it does, please let me know and, if nobody else volunteers, I'll see
> if I can come up with a set of patches to fix this for any other boards
> that have the same issue.
Actually, it needs a very small "tweak" to work :
- REGULATOR_SUPPLY("power", "pwm-backlight.0"),
+ REGULATOR_SUPPLY("power", "pwm-backlight"),
Without it regulator_dev_lookup() won't match the device.
Moreover, it requires a config option, CONFIG_REGULATOR_FIXED_VOLTAGE=y. That's
not a problem for my specific platform, but I haven't seen *any* PXA platform
with it activated, which means all defconfigs have to be patched, which is
unfortunate.
As for my specific mioa701, your change with the tweak is perfectly fine and
tested.
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: pwm-backlight: 3.13-rc1 regression for old arm machine
Date: Tue, 17 Dec 2013 19:31:21 +0100 [thread overview]
Message-ID: <87iounuy6e.fsf@free.fr> (raw)
In-Reply-To: <20131217095658.GD13823@ulmo.nvidia.com> (Thierry Reding's message of "Tue, 17 Dec 2013 10:57:00 +0100")
Thierry Reding <thierry.reding@gmail.com> writes:
> I hadn't anticipated that =(. In fact I had been holding this patch back
> for a release cycle because I was waiting for a specific regulator patch
> to land which provides a dummy regulator if one wasn't specified. It
> seems that that patch only works when booting from DT, though.
>
> The correct way to fix this would be to provide a lookup table with the
> dummy regulator in the board file. I've attached a patch (compile-tested
> only) that might work.
>
> If it does, please let me know and, if nobody else volunteers, I'll see
> if I can come up with a set of patches to fix this for any other boards
> that have the same issue.
Actually, it needs a very small "tweak" to work :
- REGULATOR_SUPPLY("power", "pwm-backlight.0"),
+ REGULATOR_SUPPLY("power", "pwm-backlight"),
Without it regulator_dev_lookup() won't match the device.
Moreover, it requires a config option, CONFIG_REGULATOR_FIXED_VOLTAGE=y. That's
not a problem for my specific platform, but I haven't seen *any* PXA platform
with it activated, which means all defconfigs have to be patched, which is
unfortunate.
As for my specific mioa701, your change with the tweak is perfectly fine and
tested.
Cheers.
--
Robert
next prev parent reply other threads:[~2013-12-17 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 15:52 pwm-backlight: 3.13-rc1 regression for old arm machine Robert Jarzmik
2013-12-17 9:57 ` Thierry Reding
2013-12-17 9:57 ` Thierry Reding
2013-12-17 18:31 ` Robert Jarzmik [this message]
2013-12-17 18:31 ` Robert Jarzmik
2013-12-20 9:47 ` Thierry Reding
2013-12-20 9:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iounuy6e.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.