From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915; Preallocate the lazy request
Date: Wed, 04 Sep 2013 15:05:57 +0300 [thread overview]
Message-ID: <87ioygeqqi.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1378287952-29783-3-git-send-email-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> It is possible for us to be forced to perform an allocation for the lazy
> request whilst running the shrinker. This allocation may fail, leaving
> us unable to reclaim any memory leading to premature OOM. A neat
> solution to the problem is to preallocate the request at the same time
> as acquiring the seqno for the ring transaction. This means that we can
> report ENOMEM prior to touching the rings.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
next prev parent reply other threads:[~2013-09-04 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 9:45 [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it Chris Wilson
2013-09-04 9:45 ` [PATCH 2/3] drm/i915: Rename ring->outstanding_lazy_request Chris Wilson
2013-09-04 12:05 ` Mika Kuoppala
2013-09-04 9:45 ` [PATCH 3/3] drm/i915; Preallocate the lazy request Chris Wilson
2013-09-04 12:05 ` Mika Kuoppala [this message]
2013-09-05 10:16 ` [Intel-gfx] [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it Daniel Vetter
2013-09-05 10:28 ` Chris Wilson
2013-09-05 11:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioygeqqi.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.