[ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

> On 02/05/13 11:02, Kalle Valo wrote:
>> Most of the time it does more harm than good to halt the
>> driver initialisation if the firmware version is not
>> supported. For example, sometimes it's good to test
>> something from older versions etc. So just change the
>> check to a warning.
>>
>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>> ---

[...]

>> -	ath10k_err("Firmware %s is not supported. Please use version %s (or newer)\n",
>> -		   ar->hw->wiphy->fw_version, version);
>> +	ath10k_warn("WARNING: Firmware version %s is not officially supported.\n",
>> +		    ar->hw->wiphy->fw_version);
>> +	ath10k_warn("Please upgrade to version %s (or newer)\n", version);
>>
>> -	return -EINVAL;
>> +	return 0;
>>   }
>
> Perhaps we should also be taking the abi_version (from 
> wmi_service_ready_event) into account. I'm not sure if FW really fills 
> that one out though.

AFAIK the firmware team doesn't use the abi_version for anything.

> The "or newer" doesn't seem to suit here either. If new FW has ABI 
> changes we're screwed.

You are right but we need to revisit the firmware version handling
anyway in the near future anyway so I'll just keep the warning as is for
now.

-- 
Kalle Valo