From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51103)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UKWou-0008IQ-Fh
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:34:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UKWop-0003R8-GW
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:33:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UKWop-0003Qp-9K
	for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:33:51 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1364314072-2474-3-git-send-email-stefanha@redhat.com> (Stefan
	Hajnoczi's message of "Tue, 26 Mar 2013 17:07:50 +0100")
References: <1364314072-2474-1-git-send-email-stefanha@redhat.com>
	<1364314072-2474-3-git-send-email-stefanha@redhat.com>
Date: Tue, 26 Mar 2013 17:33:51 +0100
Message-ID: <87ip4ektn4.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd
	non-blocking in socket_connect()
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, david.pravec@nethost.cz, mprivozn@redhat.com, Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Stefan Hajnoczi <stefanha@redhat.com> wrote:
> socket_connect() sets non-blocking on TCP or UNIX domain sockets if a
> callback function is passed.  Do the same for file descriptor passing,
> otherwise we could unexpectedly be using a blocking file descriptor.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  util/qemu-sockets.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index b6b78f5..298f6f2 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **errp,
>      case SOCKET_ADDRESS_KIND_FD:
>          fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
>          if (callback) {
> +            socket_set_nonblock(fd);
>              callback(fd, opaque);
>          }
>          break;

Reviewed-by: Juan Quintela <quintela@redhat.com>