From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 03/22] virtio_config: make transports implement accessors. Date: Sun, 24 Mar 2013 14:54:49 +1030 Message-ID: <87ip4he86m.fsf@rustcorp.com.au> References: <1363854584-25795-1-git-send-email-rusty@rustcorp.com.au> <1363854584-25795-4-git-send-email-rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sjur =?utf-8?Q?Br=C3=A6ndeland?= Cc: Pawel Moll , Brian Swetland , Linus Walleij , Erwan YVIN , virtualization@lists.linux-foundation.org, Christian Borntraeger List-Id: virtualization@lists.linuxfoundation.org U2p1ciBCcsOmbmRlbGFuZCA8c2p1cmJyZW5AZ21haWwuY29tPiB3cml0ZXM6Cj4gT24gVGh1LCBN YXIgMjEsIDIwMTMgYXQgOToyOSBBTSwgUnVzdHkgUnVzc2VsbCA8cnVzdHlAcnVzdGNvcnAuY29t LmF1PiB3cm90ZToKPj4gQEAgLTY1Myw4ICs2NzYsMTQgQEAgc3RhdGljIGludCB2cF9zZXRfdnFf YWZmaW5pdHkoc3RydWN0IHZpcnRxdWV1ZSAqdnEsIGludCBjcHUpCj4+ICB9Cj4+Cj4+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IHZpcnRpb19jb25maWdfb3BzIHZpcnRpb19wY2lfY29uZmlnX29wcyA9 IHsKPj4gLSAgICAgICAuZ2V0ICAgICAgICAgICAgPSB2cF9nZXQsCj4+IC0gICAgICAgLnNldCAg ICAgICAgICAgID0gdnBfc2V0LAo+PiArICAgICAgIC5nZXQ4ICAgICAgICAgICA9IHZwX2dldDgs Cj4+ICsgICAgICAgLnNldDggICAgICAgICAgID0gdnBfc2V0OCwKPj4gKyAgICAgICAuZ2V0MTYg ICAgICAgICAgPSB2cF9nZXQxNiwKPj4gKyAgICAgICAuc2V0MTYgICAgICAgICAgPSB2cF9zZXQx NiwKPj4gKyAgICAgICAuZ2V0MzIgICAgICAgICAgPSB2cF9nZXQzMiwKPj4gKyAgICAgICAuc2V0 MzIgICAgICAgICAgPSB2cF9zZXQzMiwKPj4gKyAgICAgICAuZ2V0NjQgICAgICAgICAgPSB2cF9n ZXQ2NCwKPj4gKyAgICAgICAuc2V0NjQgICAgICAgICAgPSB2cF9zZXQ2NCwKPj4gICAgICAgICAu Z2V0X3N0YXR1cyAgICAgPSB2cF9nZXRfc3RhdHVzLAo+PiAgICAgICAgIC5zZXRfc3RhdHVzICAg ICA9IHZwX3NldF9zdGF0dXMsCj4+ICAgICAgICAgLnJlc2V0ICAgICAgICAgID0gdnBfcmVzZXQs Cj4KPiBXb3VsZCBpdCBiZSBwb3NzaWJsZSB0byBtYWtlIHRoaXMgc2ltcGxlciBhbmQgbGVzcyB2 ZXJib3NlIHNvbWVob3c/Cj4gQXQgbGVhc3QgdGhyZWUgdmlydGlvIGRldmljZXM6IHZpcnRpb19w Y2lfbGVnYWN5LmMsIHZpcnRpb19tbWlvLmMgYW5kCj4gc29vbiByZW1vdGVwcm9jX3ZpcnRpby5j IHdpbGwgZHVwbGljYXRlIHZhcmlhbnRzIG9mIHRoZSBjb2RlIGFib3ZlLgo+Cj4gV2hhdCBpZiBz ZXQ4L2dldDggd2FzIG1hbmRhdG9yeSwgYW5kIHRoZSAxNiwzMiw2NCB2YXJpYW50cyB3aGVyZSBv cHRpb25hbCwKPiBhbmQgdGhlbiB2aXJ0aW9fY3JlYWRYKCkgdmlydGlvX2N3cml0ZVggZGlkIHRo ZSBtYWdpYyB0byBtYWtlIHRoaW5ncyB3b3JrPwoKQnV0IHRoaXMgaXMgYSBjYXNlIHdoZXJlIHNp bXBsZXIgYW5kIGxlc3MgdmVyYm9zZSBhcmUgb3Bwb3NpdGVzLiAgVGhlc2UKcGF0Y2hlcyBhcmUg cmVhbGx5IHN0cmFpZ2h0Zm9yd2FyZC4gIE5vb25lIGNhbiBmb3JnZXQgdG8gd3JpdGUgb3IgYXNz aWduCmFuIGFjY2Vzc29yIGFuZCBoYXZlIHN0aWxsIHdvcmsgb24geDg2IGFuZCBmYWlsIGZvciBC RSBtYWNoaW5lcy4KClNvIEkgbGlrZSBleHBsaWNpdCBhY2Nlc3NvcnMsIHNldCBieSB0aGUgYmFj a2VuZC4gIEJ1dCBpdCBkb2Vzbid0IGhhdmUKdG8gYmUgcXVpdGUgdGhpcyB1Z2x5LgoKSG93J3Mg dGhpcyAoY29tcGxldGVseSB1bnRlc3RlZCEpCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8v dmlydGlvLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW8uYwppbmRleCBlMzQyNjkyLi42ZmZhNTQy IDEwMDY0NAotLS0gYS9kcml2ZXJzL3ZpcnRpby92aXJ0aW8uYworKysgYi9kcml2ZXJzL3ZpcnRp by92aXJ0aW8uYwpAQCAtMjE5LDYgKzIxOSw3NSBAQCBvdXQ6CiB9CiBFWFBPUlRfU1lNQk9MX0dQ TChyZWdpc3Rlcl92aXJ0aW9fZGV2aWNlKTsKIAorc3RhdGljIHZvaWQgbm9jb252X2dldChzdHJ1 Y3QgdmlydGlvX2RldmljZSAqdmRldiwgdW5zaWduZWQgb2Zmc2V0LAorCQkgICAgICAgc2l6ZV90 IGxlbiwgdm9pZCAqcCkKK3sKKwl1OCAqYnVmID0gcDsKKwl3aGlsZSAobGVuKSB7CisJCSpidWYg PSB2ZGV2LT5jb25maWctPmdldDgodmRldiwgb2Zmc2V0KTsKKwkJYnVmKys7CisJCW9mZnNldCsr OworCQlsZW4tLTsKKwl9Cit9CisKK3UxNiB2aXJ0aW9fY29uZmlnX2dldF9ub2NvbnYxNihzdHJ1 Y3QgdmlydGlvX2RldmljZSAqdmRldiwgdW5zaWduZWQgb2Zmc2V0KQoreworCXUxNiB2OworCW5v Y29udl9nZXQodmRldiwgb2Zmc2V0LCBzaXplb2YodiksICZ2KTsKKwlyZXR1cm4gdjsKK30KK0VY UE9SVF9TWU1CT0xfR1BMKHZpcnRpb19jb25maWdfZ2V0X25vY29udjE2KTsKKwordTMyIHZpcnRp b19jb25maWdfZ2V0X25vY29udjMyKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2LCB1bnNpZ25l ZCBvZmZzZXQpCit7CisJdTMyIHY7CisJbm9jb252X2dldCh2ZGV2LCBvZmZzZXQsIHNpemVvZih2 KSwgJnYpOworCXJldHVybiB2OworfQorRVhQT1JUX1NZTUJPTF9HUEwodmlydGlvX2NvbmZpZ19n ZXRfbm9jb252MzIpOworCit1NjQgdmlydGlvX2NvbmZpZ19nZXRfbm9jb252NjQoc3RydWN0IHZp cnRpb19kZXZpY2UgKnZkZXYsIHVuc2lnbmVkIG9mZnNldCkKK3sKKwl1NjQgdjsKKwlub2NvbnZf Z2V0KHZkZXYsIG9mZnNldCwgc2l6ZW9mKHYpLCAmdik7CisJcmV0dXJuIHY7Cit9CitFWFBPUlRf U1lNQk9MX0dQTCh2aXJ0aW9fY29uZmlnX2dldF9ub2NvbnY2NCk7CisKK3N0YXRpYyB2b2lkIG5v Y29udl9zZXQoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsIHVuc2lnbmVkIG9mZnNldCwKKwkJ ICAgICAgIHNpemVfdCBsZW4sIGNvbnN0IHZvaWQgKnApCit7CisJY29uc3QgdTggKmJ1ZiA9IHA7 CisJd2hpbGUgKGxlbikgeworCQl2ZGV2LT5jb25maWctPnNldDgodmRldiwgb2Zmc2V0LCAqYnVm KTsKKwkJYnVmKys7CisJCW9mZnNldCsrOworCQlsZW4tLTsKKwl9Cit9CisKK3ZvaWQgdmlydGlv X2NvbmZpZ19zZXRfbm9jb252MTYoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCisJCQkJdW5z aWduZWQgb2Zmc2V0LCB1MTYgdikKK3sKKwlub2NvbnZfc2V0KHZkZXYsIG9mZnNldCwgc2l6ZW9m KHYpLCAmdik7Cit9CitFWFBPUlRfU1lNQk9MX0dQTCh2aXJ0aW9fY29uZmlnX3NldF9ub2NvbnYx Nik7CisKK3ZvaWQgdmlydGlvX2NvbmZpZ19zZXRfbm9jb252MzIoc3RydWN0IHZpcnRpb19kZXZp Y2UgKnZkZXYsCisJCQkJdW5zaWduZWQgb2Zmc2V0LCB1MzIgdikKK3sKKwlub2NvbnZfc2V0KHZk ZXYsIG9mZnNldCwgc2l6ZW9mKHYpLCAmdik7Cit9CitFWFBPUlRfU1lNQk9MX0dQTCh2aXJ0aW9f Y29uZmlnX3NldF9ub2NvbnYzMik7CisKK3ZvaWQgdmlydGlvX2NvbmZpZ19zZXRfbm9jb252NjQo c3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCisJCQkJdW5zaWduZWQgb2Zmc2V0LCB1NjQgdikK K3sKKwlub2NvbnZfc2V0KHZkZXYsIG9mZnNldCwgc2l6ZW9mKHYpLCAmdik7Cit9CitFWFBPUlRf U1lNQk9MX0dQTCh2aXJ0aW9fY29uZmlnX3NldF9ub2NvbnY2NCk7CisKIHZvaWQgdW5yZWdpc3Rl cl92aXJ0aW9fZGV2aWNlKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpCiB7CiAJaW50IGluZGV4 ID0gZGV2LT5pbmRleDsgLyogc2F2ZSBmb3IgYWZ0ZXIgZGV2aWNlIHJlbGVhc2UgKi8KZGlmZiAt LWdpdCBhL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5oIGIvaW5jbHVkZS9saW51eC92aXJ0 aW9fY29uZmlnLmgKaW5kZXggOWRmZTExNi4uOWE5YWFhMCAxMDA2NDQKLS0tIGEvaW5jbHVkZS9s aW51eC92aXJ0aW9fY29uZmlnLmgKKysrIGIvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgK QEAgLTI4Niw0ICsyODYsMjMgQEAgc3RhdGljIGlubGluZSB2b2lkIHZpcnRpb19jd3JpdGU2NChz dHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwKIAkJX3I7CQkJCQkJCVwKIAl9KQogCisvKiBIZWxw ZXJzIGZvciBub24tZW5kaWFuIGNvbnZlcnRpbmcgdHJhbnNwb3J0cy4gKi8KK3UxNiB2aXJ0aW9f Y29uZmlnX2dldF9ub2NvbnYxNihzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwgdW5zaWduZWQg b2Zmc2V0KTsKK3UzMiB2aXJ0aW9fY29uZmlnX2dldF9ub2NvbnYzMihzdHJ1Y3QgdmlydGlvX2Rl dmljZSAqdmRldiwgdW5zaWduZWQgb2Zmc2V0KTsKK3U2NCB2aXJ0aW9fY29uZmlnX2dldF9ub2Nv bnY2NChzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwgdW5zaWduZWQgb2Zmc2V0KTsKK3ZvaWQg dmlydGlvX2NvbmZpZ19zZXRfbm9jb252MTYoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCisJ CQkJdW5zaWduZWQgb2Zmc2V0LCB1MTYgdik7Cit2b2lkIHZpcnRpb19jb25maWdfc2V0X25vY29u djMyKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2LAorCQkJCXVuc2lnbmVkIG9mZnNldCwgdTMy IHYpOwordm9pZCB2aXJ0aW9fY29uZmlnX3NldF9ub2NvbnY2NChzdHJ1Y3QgdmlydGlvX2Rldmlj ZSAqdmRldiwKKwkJCQl1bnNpZ25lZCBvZmZzZXQsIHU2NCB2KTsKKworI2RlZmluZSBWSVJUSU9f Q09ORklHX09QU19OT0NPTlYJCVwKKwkuZ2V0MTYgPSB2aXJ0aW9fY29uZmlnX2dldF9ub2NvbnYx NiwJXAorCS5zZXQxNiA9IHZpcnRpb19jb25maWdfc2V0X25vY29udjE2LAlcCisJLmdldDMyID0g dmlydGlvX2NvbmZpZ19nZXRfbm9jb252MzIsCVwKKwkuc2V0MzIgPSB2aXJ0aW9fY29uZmlnX3Nl dF9ub2NvbnYzMiwJXAorCS5nZXQ2NCA9IHZpcnRpb19jb25maWdfZ2V0X25vY29udjY0LAlcCisJ LnNldDY0ID0gdmlydGlvX2NvbmZpZ19zZXRfbm9jb252NjQKKwogI2VuZGlmIC8qIF9MSU5VWF9W SVJUSU9fQ09ORklHX0ggKi8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3Rz LmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9t YWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u