From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [RFC PATCH 2/2] virtio-net: introduce a new control to set macaddr
Date: Fri, 11 Jan 2013 11:13:04 +1030
Message-ID: <87ip741rdz.fsf@rustcorp.com.au>
References: <1357829141-25455-1-git-send-email-akong@redhat.com> <1357829141-25455-3-git-send-email-akong@redhat.com> <20130110152649.GF30731@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	qemu-devel@nongnu.org
To: "Michael S. Tsirkin" <mst@redhat.com>, akong@redhat.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:45789 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752023Ab3AKDzp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Jan 2013 22:55:45 -0500
In-Reply-To: <20130110152649.GF30731@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

"Michael S. Tsirkin" <mst@redhat.com> writes:
>> +	if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
>> +		/* Set MAC address by writing config space */
>>  		vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
>>  		                  dev->dev_addr, dev->addr_len);
>> +	}
>>  
>
> By the way, why don't we fail the command if VIRTIO_NET_F_MAC is off?
> Rusty?

Looked back through the history for this one.  I think the theory is that
if the guest doesn't set VIRTIO_NET_F_MAC, it means it doesn't care:
it's up to the guest.

Cheers,
Rusty.

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1TtVj6-0001Kg-1K
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:56:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1TtVij-0007io-D4
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:56:15 -0500
Received: from ozlabs.org ([203.10.76.45]:57877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1TtVii-0007gF-VV
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:55:53 -0500
From: Rusty Russell <rusty@rustcorp.com.au>
In-Reply-To: <20130110152649.GF30731@redhat.com>
References: <1357829141-25455-1-git-send-email-akong@redhat.com>
	<1357829141-25455-3-git-send-email-akong@redhat.com>
	<20130110152649.GF30731@redhat.com>
Date: Fri, 11 Jan 2013 11:13:04 +1030
Message-ID: <87ip741rdz.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] virtio-net: introduce a new
	control to set macaddr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, akong@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org

"Michael S. Tsirkin" <mst@redhat.com> writes:
>> +	if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
>> +		/* Set MAC address by writing config space */
>>  		vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
>>  		                  dev->dev_addr, dev->addr_len);
>> +	}
>>  
>
> By the way, why don't we fail the command if VIRTIO_NET_F_MAC is off?
> Rusty?

Looked back through the history for this one.  I think the theory is that
if the guest doesn't set VIRTIO_NET_F_MAC, it means it doesn't care:
it's up to the guest.

Cheers,
Rusty.