From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Open-code i915_gpu_idle() for handling seqno wrapping Date: Mon, 10 Dec 2012 16:01:43 +0200 Message-ID: <87ip8a2ego.fsf@gaia.fi.intel.com> References: <1355140577-6572-1-git-send-email-mika.kuoppala@intel.com> <1355140577-6572-2-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 64EA9E5CCA for ; Mon, 10 Dec 2012 06:01:49 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 10 Dec 2012 11:59:44 +0000, Chris Wilson wrote: > On Mon, 10 Dec 2012 13:56:17 +0200, Mika Kuoppala wrote: > > From: Chris Wilson > > @@ -2032,6 +2032,7 @@ i915_add_request(struct intel_ring_buffer *ring, > > } > > > > trace_i915_gem_request_add(ring, request->seqno); > > + dev_priv->last_seqno = request->seqno; > > An unnecessary addition to my patch. Indeed, that cruft got in somehow. Fix sent but msg id was eaten by bash as it contained '$' > -Chris > -- > Chris Wilson, Intel Open Source Technology Centre