From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal Date: Fri, 16 Nov 2012 11:22:09 +1030 Message-ID: <87ip96id3a.fsf@rustcorp.com.au> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org Cc: "Michael S. Tsirkin" , sjur@brendeland.net, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Amit Shah , masami.hiramatsu.pt@hitachi.com, Sjur =?utf-8?Q?Br=C3=A6ndeland?= List-Id: virtualization@lists.linuxfoundation.org QW1pdCBTaGFoIDxhbWl0LnNoYWhAcmVkaGF0LmNvbT4gd3JpdGVzOgo+IEZyb206IFNqdXIgQnLD pm5kZWxhbmQgPHNqdXIuYnJhbmRlbGFuZEBzdGVyaWNzc29uLmNvbT4KPgo+IFJlbW92ZSBidWZm ZXJzIGZyb20gdGhlIG91dC1xdWV1ZSB3aGVuIGEgcG9ydCBpcyByZW1vdmVkLiBScHJvY19zZXJp YWwKPiBjb21tdW5pY2F0ZXMgd2l0aCByZW1vdGUgcHJvY2Vzc29ycyB0aGF0IG1heSBjcmFzaCBh bmQgbGVhdmUgYnVmZmVycyBpbgo+IHRoZSBvdXQtcXVldWUuIFRoZSB2aXJ0aW8gc2VyaWFsIHBv cnRzIG1heSBoYXZlIGJ1ZmZlcnMgaW4gdGhlIG91dC1xdWV1ZQo+IGFzIHdlbGwsIGUuZy4gZm9y IG5vbi1ibG9ja2luZyBwb3J0cyBhbmQgdGhlIGhvc3QgZGlkbid0IGNvbnN1bWUgdGhlbQo+IHll dC4KPgo+IFtBbWl0OiBSZW1vdmUgV0FSTl9PTiBmb3IgZ2VuZXJpYyBwb3J0cyBjYXNlLl0KPgo+ IFNpZ25lZC1vZmYtYnk6IFNqdXIgQnLDpm5kZWxhbmQgPHNqdXIuYnJhbmRlbGFuZEBzdGVyaWNz c29uLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbWl0IFNoYWggPGFtaXQuc2hhaEByZWRoYXQuY29t PgoKSSBhbHJlYWR5IGhhdmUgdGhpcyBpbiBteSBwZW5kaW5nIHF1ZXVlOyBJJ3ZlIHByb21vdGVk IGl0IHRvIG15CnZpcnRpby1uZXh0IGJyYW5jaCBub3cuCgpUaGFua3MsClJ1c3R5LgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6 YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751310Ab2KPBQd (ORCPT ); Thu, 15 Nov 2012 20:16:33 -0500 Received: from ozlabs.org ([203.10.76.45]:36894 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146Ab2KPBQc convert rfc822-to-8bit (ORCPT ); Thu, 15 Nov 2012 20:16:32 -0500 From: Rusty Russell To: Amit Shah Cc: sjur@brendeland.net, "Michael S. Tsirkin" , linus.walleij@linaro.org, masami.hiramatsu.pt@hitachi.com, ohad@wizery.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Sjur =?utf-8?Q?Br=C3=A6ndeland?= , Amit Shah Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal In-Reply-To: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Fri, 16 Nov 2012 11:22:09 +1030 Message-ID: <87ip96id3a.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amit Shah writes: > From: Sjur Brændeland > > Remove buffers from the out-queue when a port is removed. Rproc_serial > communicates with remote processors that may crash and leave buffers in > the out-queue. The virtio serial ports may have buffers in the out-queue > as well, e.g. for non-blocking ports and the host didn't consume them > yet. > > [Amit: Remove WARN_ON for generic ports case.] > > Signed-off-by: Sjur Brændeland > Signed-off-by: Amit Shah I already have this in my pending queue; I've promoted it to my virtio-next branch now. Thanks, Rusty.