From: Markus Armbruster <armbru@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry
Date: Thu, 02 Aug 2012 10:30:56 +0200 [thread overview]
Message-ID: <87ipd1hf0f.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <49e29dcae7ac91b99d0bbee92c0ab828057d797a.1343845033.git.blauwirbel@gmail.com> (Blue Swirl's message of "Wed, 1 Aug 2012 18:21:11 +0000")
[cc: SCSI maintainer]
Blue Swirl <blauwirbel@gmail.com> writes:
> LOAD_UNLOAD and START_STOP have same value, so the table
> entry is initialized twice. Spotted by Clang compiler.
>
> Remove LOAD_UNLOAD entry since START_STOP entry already
> represents both.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> hw/scsi-bus.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index e4ec19e..a8759bc 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -1355,7 +1355,6 @@ static const char *scsi_command_name(uint8_t cmd)
> [ BLANK ] = "BLANK",
> [ MOVE_MEDIUM ] = "MOVE_MEDIUM",
> [ EXCHANGE_MEDIUM ] = "EXCHANGE MEDIUM",
> - [ LOAD_UNLOAD ] = "LOAD_UNLOAD",
> [ READ_12 ] = "READ_12",
> [ WRITE_12 ] = "WRITE_12",
> [ ERASE_12 ] = "ERASE_12/GET_PERFORMANCE",
Missed in commit 15e58a21.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2012-08-02 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:21 [Qemu-devel] [PATCH v2 0/6] Clang patches Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 1/6] sparc: fix floppy TC line setup Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords Blue Swirl
2012-08-02 8:32 ` Markus Armbruster
2012-08-02 20:52 ` Luiz Capitulino
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 4/6] user: fix accidental AREG0 use Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 5/6] xilinx_axienet: avoid useless self-assignment Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry Blue Swirl
2012-08-02 8:30 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipd1hf0f.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.