From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMhC-0007Bc-7j
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:57:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMh6-0006TY-K5
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:57:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12831)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMh6-0006TO-C6
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:57:28 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com>
	<1343235256-26310-12-git-send-email-lcapitulino@redhat.com>
Date: Thu, 26 Jul 2012 13:57:24 +0200
In-Reply-To: <1343235256-26310-12-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Wed, 25 Jul 2012 13:54:16 -0300")
Message-ID: <87ipdad9az.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Luiz Capitulino <lcapitulino@redhat.com> writes:

> The qerror.h file doesn't contain the macros anymore, the script should
> check qapi-schema-errors.json instead.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  scripts/check-qerror.sh | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/check-qerror.sh b/scripts/check-qerror.sh
> index af7fbd5..e397b4f 100755
> --- a/scripts/check-qerror.sh
> +++ b/scripts/check-qerror.sh
> @@ -16,7 +16,5 @@ check_order() {
>    return 0
>  }
>  
> -check_order 'Definitions in qerror.h must be in alphabetical order:' \
> -            grep '^#define QERR_' qerror.h
> -check_order 'Entries in qerror.c:qerror_table must be in alphabetical order:' \
> -            sed -n '/^static.*qerror_table\[\]/,/^};/s/QERR_/&/gp' qerror.c
> +check_order 'Definitions must be in alphabetical order:' \
> +            grep '^# @' qapi-schema-errors.json

I'd add the new rule in the commit that adds qapi-schema-errors.json,
and drop the old rules in the commit that deletes the old definitions.