All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] iperf: fix build on !MMU platforms
Date: Mon, 07 May 2012 22:47:02 +0200	[thread overview]
Message-ID: <87ipg7iurd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1336408773-27312-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 7 May 2012 18:39:31 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Build tested on sh2a and blackfin architectures.

Thanks. Have you sent these patches upstream?

 Thomas> ++++ b/src/Listener.cpp
 Thomas> +@@ -679,7 +679,11 @@
 Thomas> +     pid_t pid; 
 Thomas> + 
 Thomas> +     /* Create a child process & if successful, exit from the parent process */ 
 Thomas> ++#ifndef HAVE_FORK
 Thomas> ++    if ( (pid = vfork()) == -1 ) {
 Thomas> ++#else
 Thomas> +     if ( (pid = fork()) == -1 ) {
 Thomas> ++#endif
 Thomas> +         fprintf( stderr, "error in first child create\n");     
 Thomas> +         exit(0); 

I believe you aren't allowed to call exit() after vfork (but should use
_exit() instead).

http://unix.stackexchange.com/questions/5364/why-should-a-child-of-a-vfork-or-fork-call-exit-instead-of-exit
-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2012-05-07 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 16:39 [Buildroot] [PATCH 1/2] iperf: fix build on !MMU platforms Thomas Petazzoni
2012-05-07 16:39 ` [Buildroot] [PATCH 2/2] dropbear: fix " Thomas Petazzoni
2012-05-07 20:47 ` Peter Korsgaard [this message]
2012-05-11 20:23   ` [Buildroot] [PATCH 1/2] iperf: fix build " Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipg7iurd.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.