All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@student.ethz.ch>, <git@vger.kernel.org>,
	"Thomas Gummerer" <t.gummerer@gmail.com>,
	David Michael Barr <davidbarr@google.com>
Subject: Re: [PATCH 2/2] index-v4: document the entry format
Date: Tue, 1 May 2012 23:43:20 +0200	[thread overview]
Message-ID: <87ipgfd1c7.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <7vlilcczzb.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 30 Apr 2012 21:00:24 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> I am planning to merge this series early to 'master', before the GSoC
> student really starts working on the code, perhaps by this Wednesday. The
> earlier parts of this series refactor code to make things easier to
> modify, and the later parts of it demonstrate by example both:
>
>  (1) how the backward compatibility must be handled at the design level
>      [*1*]; and
>
>  (2) how such a design can be coded cleanly at the implementation level.
>
> The hope is that this will give a solidified base to build whatever new
> work on top of (perhaps call it v5).
[...]
> How do you want to proceed?

I was initially a bit reluctant to add this complexity so shortly before
the GSoC starts in earnest.  But the cleanups are really worth it, and
then it's not *that* much code for a quite substantial speedup for
webkit.

So go ahead and merge it.  Thomas can build on top, though I'm still
hoping he'll start before you complete the merge, and learn a bit about
basing work on top of unmerged topics ;-)

> I do not mind David's further work built on top of this series, but I
> think the entry-shrinkage design for v4 is good enough as-is.

My impression was that David just tossed around ideas (very
well-researched and tested ones, but still ideas) to help Thomas.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-05-01 21:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03 22:53 [PATCH 0/9] Prefix-compress on-disk index entries Junio C Hamano
2012-04-03 22:53 ` [PATCH 1/9] varint: make it available outside the context of pack Junio C Hamano
2012-04-03 22:53 ` [PATCH 2/9] cache.h: hide on-disk index details Junio C Hamano
2012-04-03 22:53 ` [PATCH 3/9] read-cache.c: allow unaligned mapping of the index file Junio C Hamano
2012-04-03 22:53 ` [PATCH 4/9] read-cache.c: make create_from_disk() report number of bytes it consumed Junio C Hamano
2012-04-03 22:53 ` [PATCH 5/9] read-cache.c: report the header version we do not understand Junio C Hamano
2012-04-03 22:53 ` [PATCH 6/9] read-cache.c: move code to copy ondisk to incore cache to a helper function Junio C Hamano
2012-04-03 22:53 ` [PATCH 7/9] read-cache.c: move code to copy incore to ondisk " Junio C Hamano
2012-04-03 22:53 ` [PATCH 8/9] read-cache.c: read prefix-compressed names in index on-disk version v4 Junio C Hamano
2012-04-03 22:53 ` [PATCH 9/9] read-cache.c: write index v4 format Junio C Hamano
2012-04-04  1:44 ` [PATCH 0/9] Prefix-compress on-disk index entries David Barr
2012-04-04 15:33   ` Junio C Hamano
2012-04-04 16:57     ` Junio C Hamano
2012-04-04 16:58       ` [PATCH 2/2] update-index: upgrade/downgrade on-disk index version Junio C Hamano
2012-04-04 12:34 ` [PATCH 0/9] Prefix-compress on-disk index entries Nguyen Thai Ngoc Duy
2012-04-04 18:44   ` Junio C Hamano
2012-04-06  8:41     ` David Barr
2012-05-02  1:58       ` Nguyen Thai Ngoc Duy
2012-05-02  4:26         ` David Barr
2012-04-27 22:58 ` [PATCH 1/2] unpack-trees: preserve the index file version of original Junio C Hamano
2012-04-27 23:02   ` [PATCH 2/2] index-v4: document the entry format Junio C Hamano
2012-04-30 17:20     ` Thomas Rast
2012-05-01  4:00       ` Junio C Hamano
2012-05-01 21:43         ` Thomas Rast [this message]
2012-05-02 15:12         ` Shawn Pearce
2012-05-02 17:04           ` Junio C Hamano
2012-05-02 17:13             ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipgfd1c7.fsf@thomas.inf.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=davidbarr@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.