From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S9y9h-0002wq-BP
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 08:27:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S9y9b-0005ab-37
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 08:27:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S9y9a-0005a0-Rr
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 08:27:07 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <CAFEAcA_AY9efdSpdaU2xpP5FLqUuyVf041Q1JCn=QBn7CZnm3Q@mail.gmail.com>
	(Peter Maydell's message of "Tue, 20 Mar 2012 11:54:30 +0000")
References: <cover.1332197811.git.quintela@redhat.com>
	<a8f59cb7e34316062409da762013740dd7fb9f2d.1332197811.git.quintela@redhat.com>
	<CAFEAcA_AY9efdSpdaU2xpP5FLqUuyVf041Q1JCn=QBn7CZnm3Q@mail.gmail.com>
Date: Tue, 20 Mar 2012 13:27:01 +0100
Message-ID: <87iphzv4oa.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 March 2012 22:57, Juan Quintela <quintela@redhat.com> wrote:
>> This way, we fix a bug (we were overwritten the 16 first registers on
>> load), and we don't need to check for ARM_FEATUR_VPF3, we always send
>> the 32 registers.
>
> This commit message is out of date -- the overwriting bug was
> fixed in commit 15180256 last year. Possibly the patch should
> be dropped from your series? (If not, "ARM_FEATURE_VFP3".)

Reason for the change is not to have to write partial arrays.
Current code is doing

if ARM_FEATURE_VFP
  send first 16 registers
  if (ARM_FEATURE_VFP3
    send second 16 registers

I change it to:

if ARM_FEATURE_VFP
   send 32 registers

Notice that:
a- there is always 32 registers
b- makes the migration format the same for VFP and VFP3
c- we are already incompatible with previous versions, so this is not a
problem.

Normally, the less different options that we have on the migration
format, the easy to make sense of it.  It was not related to the bug
that we used to have in this area.

Later, Juan.