Re: [Qemu-devel] [PATCH] pc: map pc ram from user-specified file

[Juan Quintela <quintela@redhat.com>]

Peter Feiner <peter@gridcentric.ca> wrote:
> Enables providing a backing file for the PC's ram. The file is specified by the
> new -pcram-file option. The file is mmap'd shared, so the RAMBlock that it backs
> doesn't need to be saved by vm_save / migration.
>
> Signed-off-by: Peter Feiner <peter@gridcentric.com>

Hi

Do you have any performance number for this?  And examples on how your
are using it?

> +#ifdef __linux__
> +    new_block->host = mem_file_ram_alloc(new_block, size);
> +    if (new_block->host) {
> +        assert(!host);
> +    } else
> +#endif
>      if (host) {

This test is (at least suspicious).  Shouldn't we check first if host
is not NULL? (Not that I fully understand that part)

Thanks, Juan.