All of lore.kernel.org
 help / color / mirror / Atom feed
From: JJ Ding <jj_ding@emc.com.tw>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Aaron Huang" <aaron_huang@emc.com.tw>,
	"Tom Lin" <tom_lin@emc.com.tw>,
	"Éric Piel" <E.A.B.Piel@tudelft.nl>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: elantech - add resolution query support for v4 hardware
Date: Fri, 18 Nov 2011 18:19:02 +0800	[thread overview]
Message-ID: <87ipmh91ih.fsf@emc.com.tw> (raw)
In-Reply-To: <CAGS+omCnQGyw3j=B7JxTwtsu0Vn+_iT1+y8tN72_zxo4Z09=bQ@mail.gmail.com>

Hi Daniel,

Thanks for your suggestion, I'll send new patches to do this next week.

jj

On Fri, 18 Nov 2011 16:08:53 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote:
> Hi JJ,
> 
> 
> You might consider allowing this command to fail, but just log a
> warning message.
> Then only do the input_abs_set_res() if x_res / y_res != 0.
> 
> Otherwise, for both patches in this set:
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> 

      reply	other threads:[~2011-11-18 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 10:16 [PATCH 0/2] some updates for newer elantech touchpads JJ Ding
2011-11-17 10:16 ` [PATCH 1/2] Input: elantech - add support for elantech fast command JJ Ding
2011-11-17 10:16 ` [PATCH 2/2] Input: elantech - add resolution query support for v4 hardware JJ Ding
2011-11-18  8:08   ` Daniel Kurtz
2011-11-18 10:19     ` JJ Ding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipmh91ih.fsf@emc.com.tw \
    --to=jj_ding@emc.com.tw \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=aaron_huang@emc.com.tw \
    --cc=djkurtz@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=tom_lin@emc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.