All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH] OMAP3: disable idle early in the suspend sequence
Date: Tue, 07 Dec 2010 17:11:51 -0800	[thread overview]
Message-ID: <87ipz5hxuw.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1290422697-2300-1-git-send-email-j-pihet@ti.com> (Jean Pihet's message of "Mon, 22 Nov 2010 11:44:57 +0100")

Hi Jean,

Jean Pihet <jean.pihet@newoldbits.com> writes:

> Some bad interaction between the idle and the suspend paths has been
> noticed: the idle code is called during the suspend enter and exit
> sequences. This could cause corruption or lock-up of resources.
>
> The solution is to move the call to disable_hlt at the very beginning
> of the suspend sequence (in omap3_pm_begin instead of omap3_pm_prepare),
> and the call to enable_hlt at the very end of the suspend sequence
> (in omap3_pm_end instead of omap3_pm_finish).
>
> Tested with RET and OFF on Beagle and OMAP3EVM.
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Can you update this to do similar for OMAP2 and OMAP4?

Thanks,

Kevin

  parent reply	other threads:[~2010-12-08  1:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 10:44 [PATCH] OMAP3: disable idle early in the suspend sequence Jean Pihet
2010-11-22 10:53 ` Rajendra Nayak
2010-11-22 11:30   ` Jean Pihet
2010-11-22 12:35     ` Rajendra Nayak
2010-11-22 11:11 ` Felipe Balbi
2010-11-22 11:38   ` Jean Pihet
2010-11-22 11:45     ` Felipe Balbi
2010-11-22 17:51 ` Kevin Hilman
2010-11-22 19:40   ` Jean Pihet
2010-12-08  1:11 ` Kevin Hilman [this message]
2010-12-08  9:11   ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipz5hxuw.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.