Re: [PATCH 1/2] huawei: poll sim state

[Kalle Valo <kalle.valo@canonical.com>]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Denis Kenzior <denkenz@gmail.com> writes:

> Hi Kalle,

Hi Denis,

> On 08/10/2010 04:57 AM, Kalle Valo wrote:
>
>> In theory it might be possible to do this better, for example follow
>> ^BOOT notifications or something, but it's unknown what parameter we
>> should check for.

Do you know if I can use BOOT messages (or something else) here? Polling
usually creates a load of problems and I would like to avoid it at all
costs.

>> +		/* SIM is not ready, try again a bit later */
>> +		data->query_sim_state =
>> +			g_timeout_add_seconds(2, query_sim_state, modem);
>> +	}
>
> Polling the sim state forever might not be a good idea if the SIM is not
> inserted in the first place.  You might want to give up after several
> tries or so.

Good point. I'll add a counter for this (unless I can think of something
else).

-- 
Kalle Valo