From: Kevin Hilman <khilman@deeprootsystems.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3] arm: omap1/2/3/4: convert clocksource to a platform_driver
Date: Tue, 23 Mar 2010 19:07:31 +0100 [thread overview]
Message-ID: <87iq8mc3oc.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1269350966-9311-1-git-send-email-felipe.balbi@nokia.com> (Felipe Balbi's message of "Tue\, 23 Mar 2010 15\:29\:26 +0200")
Felipe Balbi <felipe.balbi@nokia.com> writes:
> Convert the omap32k clocksource driver into a platform_driver
> and while at that, also remove the ifdeferry around the code.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Looks like a good direction, but it still is rather tied to the 32k
sync timer. We also have the ability to use a GPtimer as a
clocksource (see the clocksource register in timer-gp.c.) By default,
we are always using the 32k timer for PM reasons, but we need the ability
to register any timer as clocksource. This problably means just splitting
a little more the driver part and the device part.
Also, the new clocksource.c file should reference from whence it came.
A lot of that was copy/pasted from the older code so copyrights/author
credits should follow.
Kevin
next prev parent reply other threads:[~2010-03-23 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 12:12 [PATCH] arm: omap1/2/3/4: convert clocksource to a platform_driver Felipe Balbi
2010-03-23 12:23 ` [PATCH v2] " Felipe Balbi
2010-03-23 13:29 ` [PATCH v3] " Felipe Balbi
2010-03-23 13:42 ` [PATCH] arm: omap1/2/3/4: change sync_32k_ick to ick Felipe Balbi
2010-03-23 18:07 ` Kevin Hilman [this message]
2010-03-24 6:34 ` [PATCH v3] arm: omap1/2/3/4: convert clocksource to a platform_driver Felipe Balbi
2010-03-24 6:54 ` Felipe Balbi
2010-03-26 7:21 ` [PATCH] " Felipe Balbi
2010-04-05 22:57 ` Kevin Hilman
2010-04-06 6:38 ` Felipe Balbi
2010-04-06 14:43 ` Kevin Hilman
2010-04-06 15:26 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iq8mc3oc.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.