From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one
Date: Thu, 11 Mar 2010 18:03:20 +0900 [thread overview]
Message-ID: <87iq93s013.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <5ec8ebd51003102314n73723b11s10fa4c3564cce884@mail.gmail.com> (Andy Shevchenko's message of "Thu, 11 Mar 2010 09:14:04 +0200")
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Thu, Mar 11, 2010 at 1:18 AM, OGAWA Hirofumi
> <hirofumi@mail.parknet.co.jp> wrote:
>>> + *op++ = hex_asc_hi(ec >> 8);
>>> + *op++ = hex_asc_lo(ec >> 8);
>>> + *op++ = hex_asc_hi(ec);
>>> + *op++ = hex_asc_lo(ec);
>> Why doesn't this use pack_hex_byte()?
> No specific reason, it could be so. Would you like me to change this?
Yes, please change it if you have no problem.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2010-03-11 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1268261495-686-1-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-2-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-3-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-4-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-5-git-send-email-andy.shevchenko@gmail.com>
2010-03-10 23:18 ` [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one OGAWA Hirofumi
2010-03-11 7:14 ` Andy Shevchenko
2010-03-11 9:03 ` OGAWA Hirofumi [this message]
2010-03-11 15:00 ` [PATCHv2] fs: fat: use pack_hex_byte() " Andy Shevchenko
2010-03-11 15:12 ` OGAWA Hirofumi
2010-03-11 15:15 ` Andy Shevchenko
[not found] ` <1268468961-17033-1-git-send-email-andy.shevchenko@gmail.com>
2010-03-13 11:09 ` [PATCHv3] " OGAWA Hirofumi
2010-03-11 7:21 ` [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi " Joe Perches
2010-03-11 7:59 ` Andy Shevchenko
2010-03-11 8:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iq93s013.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.