From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] omap2/3/4: serial: Don't init UART4 for 3630 still Date: Wed, 24 Feb 2010 06:33:11 -0800 Message-ID: <87iq9mu2jc.fsf@deeprootsystems.com> References: <1267002144-21944-1-git-send-email-saaguirre@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qy0-f179.google.com ([209.85.221.179]:33028 "EHLO mail-qy0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754902Ab0BXOdR (ORCPT ); Wed, 24 Feb 2010 09:33:17 -0500 Received: by qyk9 with SMTP id 9so389535qyk.5 for ; Wed, 24 Feb 2010 06:33:16 -0800 (PST) In-Reply-To: (Sergio Aguirre's message of "Wed\, 24 Feb 2010 05\:24\:03 -0600") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Aguirre, Sergio" Cc: Tony Lindgren , "linux-omap@vger.kernel.org" , "Pandita, Vikram" , "Sonasath, Moiz" "Aguirre, Sergio" writes: >> -----Original Message----- >> From: Aguirre, Sergio >> Sent: Wednesday, February 24, 2010 3:02 AM >> To: Tony Lindgren >> Cc: linux-omap@vger.kernel.org; Pandita, Vikram; Sonasath, Moiz; Aguirre, >> Sergio >> Subject: [PATCH] omap2/3/4: serial: Don't init UART4 for 3630 still >> >> The patch named: >> "omap2/3/4: Fix mach-omap2/serial.c for multiboot" >> >> Which added UART4 init also for 36xx based boards, broke zoom3 >> booting. >> >> In theory, for zoom3 case, we should have UART4 + external debugboard >> UART running with no issues. But unless the real issue is fixed, >> this patch is crucial for Zoom3 booting. > > Just FYI, > > I tried by changing id field in board-zoom-debugboard.c for external > UART to -1, which in theory would add a ttyS4, but somehow it didn't > worked for me... That id field should probably be just changed to 4, or better it should be changed to use a symbolic constant that reflects the max number of on-chip UARTs. Kevin > I guess the proper fix will be to have: > > ttyS0 - OMAP3_UART1 > ttyS1 - OMAP3_UART2 > ttyS2 - OMAP3_UART3 > ttyS3 - OMAP3_UART4 > ttyS4 - ZOOM_UART > > Any Zoom debugboard expert that wants to comment on this? >> >> Signed-off-by: Sergio Aguirre >> --- >> arch/arm/mach-omap2/serial.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c >> index b79bc89..c4a810b 100644 >> --- a/arch/arm/mach-omap2/serial.c >> +++ b/arch/arm/mach-omap2/serial.c >> @@ -764,7 +764,7 @@ void __init omap_serial_init(void) >> { >> int i, nr_ports; >> >> - if (!(cpu_is_omap3630() || cpu_is_omap4430())) >> + if (!cpu_is_omap4430()) >> nr_ports = 3; >> else >> nr_ports = ARRAY_SIZE(omap_uart); >> -- >> 1.6.3.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html