From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1My4Ve-0002D7-8T
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:07:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1My4VX-0002Ag-VV
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:07:20 -0400
Received: from [199.232.76.173] (port=57047 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1My4VW-0002AA-Av
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:07:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25788)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1My4VV-00075O-MQ
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:07:14 -0400
References: <1255453026-18637-1-git-send-email-lcapitulino@redhat.com>
	<1255453026-18637-6-git-send-email-lcapitulino@redhat.com>
	<87eip7550j.fsf@pike.pond.sub.org> <4AD5CEB9.80104@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 14 Oct 2009 16:07:11 +0200
In-Reply-To: <4AD5CEB9.80104@redhat.com> (Paolo Bonzini's message of "Wed\,
	14 Oct 2009 15\:14\:33 +0200")
Message-ID: <87iqei133k.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 5/9] monitor: QError support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, kraxel@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 10/13/2009 11:59 PM, Markus Armbruster wrote:
>>> >  +void qemu_error_structed(QErrorCode code, const char *fmt, ...);
>> Needs __attribute__((format(printf, 2, 3))).
>
> If I read the code correctly, qemu_object_from_va is what in the end
> processes the valist and it is not exactly compatible with printf
> syntax.  For example, in patch 7/9 you have
>
>      qemu_error_structed(QERR_QDEV_NFOUND, "{ s: s }", "name", driver);

You're right, of course.

Pity we lose the checking.