From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command
Date: Fri, 25 Sep 2009 03:50:03 +0200 [thread overview]
Message-ID: <87iqf76bec.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <20090924163123.5eec5c90@doriath> (Luiz Capitulino's message of "Thu\, 24 Sep 2009 16\:31\:23 -0300")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Thu, 24 Sep 2009 20:12:30 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> My major complaint is that I'd rather see the code cleaned up there.
>> It's perfectly fine for code that can run only during startup to
>> terminate the program on configuration error. Code to be used after
>> startup (used from monitor, in particular) must not do that. Instead,
>> it should return failure up the call chain, until we reach either
>> startup code or monitor code, where the policy how to handle the error
>> resides.
>
> What cleanup do you suggest?
>
> Note that it's not only about exit(), the function also has some
> fprintf()s. If a big refactor is needed to properly fix this,
> I guess we will have to live with the bug for a long time...
See the patch series I'm going to post.
next prev parent reply other threads:[~2009-09-25 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 14:16 [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command Luiz Capitulino
2009-09-24 18:12 ` Markus Armbruster
2009-09-24 19:31 ` Luiz Capitulino
2009-09-25 1:50 ` Markus Armbruster [this message]
2009-09-24 20:07 ` Mark McLoughlin
2009-09-25 1:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqf76bec.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.