All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH 3/3] Make sure we free the struct socket of SOCK_DEAD sockets
Date: Mon, 14 Sep 2009 12:31:02 -0700	[thread overview]
Message-ID: <87iqfljpc9.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <4AAE94D7.6060802-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org> (Oren Laadan's message of "Mon\, 14 Sep 2009 15\:09\:11 -0400")

OL> This works well for the case of successful restart, but I suspect it
OL> doesn't cover two other cases:

OL> 1) Malicious user removes the SOCK_DEAD marking off a socket.
OL> 2) Restart fails after a socket is restored but before it is
OL> attached to a process.

Aww, come on... when are users ever malicious? :)

Okay, I think I can handle both of these with a carefully-crafted
obj->ops->drop() replacement.  I don't want to get back to the
orphan-all-by-default situation because it becomes hard to ensure that
the socket object we later allocate receives proper treatment.

Thanks.

-- 
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

  parent reply	other threads:[~2009-09-14 19:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 16:48 Sockets as proper objhash objects Dan Smith
     [not found] ` <1252946924-4401-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-14 16:48   ` [PATCH 1/3] Make sockets proper objhash objects and use checkpoint_obj() on them (v3) Dan Smith
2009-09-14 16:48   ` [PATCH 2/3] Track socket buffer owners (v3) Dan Smith
2009-09-14 16:48   ` [PATCH 3/3] Make sure we free the struct socket of SOCK_DEAD sockets Dan Smith
     [not found]     ` <1252946924-4401-4-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-14 19:09       ` Oren Laadan
     [not found]         ` <4AAE94D7.6060802-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-14 19:31           ` Dan Smith [this message]
2009-09-14 19:27   ` Sockets as proper objhash objects Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqfljpc9.fsf@caffeine.danplanet.com \
    --to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.