From: Andi Kleen <andi@firstfloor.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] syncookies: remove last_synq_overflow from struct tcp_sock
Date: Mon, 20 Apr 2009 12:13:49 +0200 [thread overview]
Message-ID: <87iqkzpr8i.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1240170228-26241-1-git-send-email-fw@strlen.de> (Florian Westphal's message of "Sun, 19 Apr 2009 21:43:48 +0200")
Florian Westphal <fw@strlen.de> writes:
>
> We can (ab)use rx_opt.ts_recent_stamp to store the same information;
> it is not used otherwise as long as a socket is in listen state.
You should add a comment to the declaration of the structure for this.
Or better use a union to make it clear.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2009-04-20 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 19:43 [PATCH] syncookies: remove last_synq_overflow from struct tcp_sock Florian Westphal
2009-04-20 9:26 ` David Miller
2009-04-20 10:13 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqkzpr8i.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.