From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAq8j-0003Lq-KR for mharc-grub-devel@gnu.org; Fri, 04 Jan 2008 12:15:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAq8h-0003KR-W7 for grub-devel@gnu.org; Fri, 04 Jan 2008 12:15:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAq8e-0003Hz-6P for grub-devel@gnu.org; Fri, 04 Jan 2008 12:15:21 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAq8d-0003Hw-Uk for grub-devel@gnu.org; Fri, 04 Jan 2008 12:15:19 -0500 Received: from neonescio.viaisn.org ([82.94.249.43]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAq8d-0006yG-I0 for grub-devel@gnu.org; Fri, 04 Jan 2008 12:15:19 -0500 Received: from dijkstra.dekkers.cx ([2001:960:7a0:0:213:d4ff:fe9c:2487] ident=Debian-exim) by neonescio.viaisn.org with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32 CV=0) (Exim 4.63 #1) id 1JAq8c-0003wV-9z for grub-devel@gnu.org; Fri, 04 Jan 2008 18:15:18 +0100 Received: from localhost ([127.0.0.1] helo=dijkstra.dekkers.cx ident=jeroen) by dijkstra.dekkers.cx with esmtp (Exim 4.68) (envelope-from ) id 1JAq8b-0007U1-F2 for grub-devel@gnu.org; Fri, 04 Jan 2008 18:15:17 +0100 Date: Fri, 04 Jan 2008 18:15:17 +0100 Message-ID: <87ir29342i.wl@dekkers.cx> From: Jeroen Dekkers To: The development of GRUB 2 In-Reply-To: <20071016210907.GA10870@thorin> References: <20071016210907.GA10870@thorin> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.1 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] split realmode and loader routines out of startup.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 17:15:24 -0000 At Tue, 16 Oct 2007 23:09:07 +0200, Robert Millan wrote: > This patch splits realmode and loader routines out of startup.S. The idea > is that the LinuxBIOS port can be adapted to share more code with the rest > of GRUB instead of duplicating it. > > This is quite critical stuff, so even if the change seems trivial I'd suggest > being careful, since I don't trust myself too much. Of course, I've tested > that it can still boot Linux and Multiboot (on qemu only). Perhaps testing > on real hardware would be appropiate (but I don't have this handy atm). > * kern/i386/pc/startup.S (protstack): Moved to ... > * kern/i386/realmode.S (protstack): ... here. > * kern/i386/pc/startup.S (gdt): Moved to ... > * kern/i386/realmode.S (gdt): ... here. > * kern/i386/pc/startup.S (prot_to_real): Moved to ... > * kern/i386/realmode.S (prot_to_real): ... here. > > * kern/i386/pc/startup.S: Include `kern/i386/loader.S' and > `kern/i386/realmode.S'. Why did you move prot_to_real to realmode.S, but not real_to_prot? That seems a bit strange to me... Jeroen Dekkers