From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1GSwBl-0003zv-Nf for mharc-grub-devel@gnu.org; Thu, 28 Sep 2006 09:44:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GSwBj-0003v4-IV for grub-devel@gnu.org; Thu, 28 Sep 2006 09:44:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GSwBh-0003sy-Qj for grub-devel@gnu.org; Thu, 28 Sep 2006 09:44:30 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GSwBh-0003sv-MB for grub-devel@gnu.org; Thu, 28 Sep 2006 09:44:29 -0400 Received: from [194.109.24.22] (helo=smtp-vbr2.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GSwGn-0005WU-98 for grub-devel@gnu.org; Thu, 28 Sep 2006 09:49:45 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr2.xs4all.nl (8.13.8/8.13.8) with ESMTP id k8SDiS3R015585 for ; Thu, 28 Sep 2006 15:44:28 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1159444090.451bb67a38fba@imp6-g19.free.fr> <87d59g9jku.fsf@night.trouble.net> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 28 Sep 2006 15:52:22 +0200 In-Reply-To: <87d59g9jku.fsf@night.trouble.net> (Johan Rydberg's message of "Thu, 28 Sep 2006 16:01:05 +0200") Message-ID: <87irj814kp.fsf@xs4all.nl> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner Subject: Re: patch for kern/efi/mm.c (big memmap) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2006 13:44:31 -0000 Johan Rydberg writes: > + memory_map = grub_efi_allocate_pages > + (0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000)); > > I suppose you add 0x1000 to round it up. Maybe we should change the > BYTES_TO_PAGES macro to do roundup. Agreed. Can you make this change as well? > I'll attach a unified diff, since those is easier to review. Wow, I have two unified diffs now, you both make my day. ;-) > Even through this patch is quite trivial and small, I believe we need > you to sign over the copyright for it to FSF. Okuji, Marco, what are > your opinions? This patch is trivial enough to apply without the paperwork, I think. -- Marco