From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dnvtk-0006yn-5n for mharc-grub-devel@gnu.org; Thu, 30 Jun 2005 06:03:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DnvtZ-0006ta-7h for grub-devel@gnu.org; Thu, 30 Jun 2005 06:03:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DnvtS-0006qr-Ub for grub-devel@gnu.org; Thu, 30 Jun 2005 06:03:41 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DnvtS-0006oU-K1 for grub-devel@gnu.org; Thu, 30 Jun 2005 06:03:38 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DnvwV-0007Eb-UE for grub-devel@gnu.org; Thu, 30 Jun 2005 06:06:48 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 85A7E8DD6 for ; Thu, 30 Jun 2005 12:01:45 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 02714-05 for ; Thu, 30 Jun 2005 11:06:25 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 1C0D78DF1 for ; Thu, 30 Jun 2005 12:01:43 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id B175EC047 for ; Thu, 30 Jun 2005 12:01:42 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050629083358.250134cc@localhost> <42C2BC69.8080102@yahoo.fr> <42C2C55F.9010203@yahoo.fr> From: Marco Gerards Date: Thu, 30 Jun 2005 12:01:42 +0200 In-Reply-To: <42C2C55F.9010203@yahoo.fr> (Vincent Pelletier's message of "Wed, 29 Jun 2005 17:59:27 +0200") Message-ID: <87irzwf9ix.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [PATCH] grub2: commands/cmp.c: grub_cmd_cmp() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2005 10:03:50 -0000 Vincent Pelletier writes: Hi Vincent, Thanks for your patch. It looks ok to me. A few small comments... > 2005-06-29 Vincent Pelletier > > * commands/cmp.c > (grub_cmd_cmp): Close the right file at the right time. Compare > only data just read. Don't report files of different size as > identical. (BLOCK_SIZE): New macro. The (BLOCK_SIZE) stuff should be put on a new line. I think BUFFER_SIZE would be a better name. Another size can be used. Perhaps it is better to use a bigger buffer size? > > if (grub_file_size (file1) != grub_file_size (file2)) > - grub_printf ("Differ in size: %d [%s], %d [%s]\n", > - grub_file_size (file1), args[0], > - grub_file_size (file2), args[1]); > + { > + grub_printf ("Differ in size: %d [%s], %d [%s]\n", > + grub_file_size (file1), args[0], > + grub_file_size (file2), args[1]); > + } Huh? Thanks, Marco