From: Ed L Cashin <ecashin@coraid.com>
To: Andi Kleen <ak@muc.de>
Cc: Jens Axboe <axboe@suse.de>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
jgarzik@pobox.com
Subject: Re: [BUG] ATA over Ethernet __init calling __exit
Date: Thu, 13 Jan 2005 17:59:09 -0500 [thread overview]
Message-ID: <87is613phe.fsf@coraid.com> (raw)
In-Reply-To: 20050113224832.GA19673@muc.de
Andi Kleen <ak@muc.de> writes:
> On Thu, Jan 13, 2005 at 05:12:21PM -0500, Ed L Cashin wrote:
>
>> It seems rash to make the change now, because there is no need for it.
>
> It would be better to future proof the driver at least a bit.
>
>>
>> For the skbuffs, we could use a mempool with GFP_NOIO allocation and
>> then skb_get them before the network layer ever sees them. We already
>> keep track of the packets that we've sent out, so we'll just keep a
>> pointer to the skbuffs.
>
> That won't work because you don't know when the driver is done with it.
>
> There is a callback, but it's already used by socket buffer management
The destructor member of struct sk_buff, right?
> (if you don't use a socket it may be usable)
You mean a struct sock? No, we don't use that because we're not IP.
Thanks for the lead.
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2005-01-13 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 0:09 [BUG] ATA over Ethernet __init calling __exit Russell King
2005-01-13 8:50 ` Jens Axboe
2005-01-13 19:36 ` Andi Kleen
2005-01-13 20:52 ` Ed L Cashin
2005-01-13 21:53 ` Andi Kleen
2005-01-13 22:09 ` Alan Cox
2005-01-13 22:12 ` Ed L Cashin
2005-01-13 22:48 ` Andi Kleen
2005-01-13 22:59 ` Ed L Cashin [this message]
2005-01-13 17:35 ` [PATCH] " Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87is613phe.fsf@coraid.com \
--to=ecashin@coraid.com \
--cc=ak@muc.de \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.