From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CJE9J-0003C6-HH for mharc-grub-devel@gnu.org; Sun, 17 Oct 2004 12:44:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CJE9H-0003Bs-VL for grub-devel@gnu.org; Sun, 17 Oct 2004 12:44:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CJE9G-0003BK-Tf for grub-devel@gnu.org; Sun, 17 Oct 2004 12:44:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJE9G-0003BA-R4 for grub-devel@gnu.org; Sun, 17 Oct 2004 12:44:46 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CJE1w-0008An-F8 for grub-devel@gnu.org; Sun, 17 Oct 2004 12:37:12 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 076EA8446 for ; Sun, 17 Oct 2004 18:37:11 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 20248-09 for ; Sun, 17 Oct 2004 18:37:09 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 21A4283FD for ; Sun, 17 Oct 2004 18:37:09 +0200 (CEST) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 4BE67C046 for ; Sun, 17 Oct 2004 18:37:02 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20041016004802.GA13232@miracle> <87mzynj9ak.fsf@marco.marco-g.com> <28ED5A02-1F85-11D9-8A15-000A95A0560C@penguinppc.org> From: Marco Gerards Date: Sun, 17 Oct 2004 16:36:57 +0000 In-Reply-To: <28ED5A02-1F85-11D9-8A15-000A95A0560C@penguinppc.org> (Hollis Blanchard's message of "Sat, 16 Oct 2004 10:07:56 -0500") Message-ID: <87is99nvx2.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: [ppc patch] ASFLAGS and CFLAGS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 16:44:48 -0000 Hollis Blanchard writes: > On Oct 16, 2004, at 4:34 AM, Marco Gerards wrote: > >> Hollis Blanchard writes: >> >>> I haven't yet resolved the genmk.rb issues with listing grubof in >>> sbin_UTILITIES. We don't want grubof to be an "IMAGE", as that does an >>> objcopy -O binary. So I think a new class is required in genmk.rb... >>> perhaps called pkgdata_ELF or so. >> >> Perhaps you can prevent that when using the proper LDFLAGS for grubof >> only. I prefer that over what you did in this patch, if that also >> fixes the problem. > > I don't understand. There are a few problems: > - -msoft-float is missing from COMMON_CFLAGS I think the best thing is to add this until all code depending on this is removed. > - COMMON_ASFLAGS contains C-specific flags (-nostdinc -fno-builtin) This is just copied from i386-pc.rmk. I assume there was a good reason for this so I copied this. Please leave it there unless there is a good reason to remove it or Okuji says it is not required. > - COMMON_CFLAGS contains assmebly-specific flags (-D__ASSEMBLY__) This is a stupid copy-paste mistake from me. > My patch addresses all three problems, with the caveat that > COMMON_ASFLAGS is not actually used yet. To use COMMON_ASFLAGS, we > need to fix genmk.rb. Changing LDFLAGS would have no effect on the > problems listed above. The problem I talked about is that COMMON_ASFLAGS is not used. You are right genmk.rb might need to be fixed, I do not know. But using pkgdata_IMAGES would be the right thing to do, AFAIK. The best thing to do is fixing both issues. Thanks, Marco